From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 80C3B8E80
 for <dev@dpdk.org>; Tue, 20 Oct 2015 13:18:22 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 20 Oct 2015 04:18:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,707,1437462000"; d="scan'208";a="797899741"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by orsmga001.jf.intel.com with ESMTP; 20 Oct 2015 04:18:20 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.229]) with mapi id 14.03.0248.002;
 Tue, 20 Oct 2015 12:18:19 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from
 rte_pci_driver to rte_eth_dev_data
Thread-Index: AQHRBQq/JnZfMGu1sk2SrOtL3+5lwJ50QuDg
Date: Tue, 20 Oct 2015 11:18:19 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F7260A@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1444667120-12891-1-git-send-email-bernard.iremonger@intel.com>
 <1444667120-12891-3-git-send-email-bernard.iremonger@intel.com>
 <533710CFB86FA344BFBF2D6802E6028621B4E0C5@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <533710CFB86FA344BFBF2D6802E6028621B4E0C5@SHSMSX101.ccr.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 02/20] librte_ether: add fields
	from	rte_pci_driver to rte_eth_dev_data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2015 11:18:22 -0000

Hi  Michael,

<snip>

> > @@ -1795,8 +1790,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct
> rte_eth_dev_info *dev_info)
> >  	FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get);
> >  	(*dev->dev_ops->dev_infos_get)(dev, dev_info);
> >  	dev_info->pci_dev =3D dev->pci_dev;
>=20
> Here also pci_dev, I think after you remove pci_dev from vdevs, and this
> field could be remove I think, as I don't see any use of this field in de=
v_info, it
> should be more general and not only PCI.
>=20
> Thanks,
> Michael

<snip>

At present there are PCI  pdevs  and vdevs without PCI.
The field is still relevant  for the pdevs, for the vdevs it will be NULL.
I would prefer to retain this field.
This patch set is not intended to handle other bus types.

Regards,

Bernard.