From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 946098E6E for ; Mon, 2 Nov 2015 11:24:44 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 02 Nov 2015 02:24:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="676532357" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga003.jf.intel.com with ESMTP; 02 Nov 2015 02:24:43 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 2 Nov 2015 10:24:42 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by irsmsx155.ger.corp.intel.com ([169.254.14.242]) with mapi id 14.03.0248.002; Mon, 2 Nov 2015 10:24:42 +0000 From: "Iremonger, Bernard" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v7 03/28] librte_ether: add function rte_eth_copy_dev_info Thread-Index: AQHRFOy9AQm06IJSgEmNofV5zgOpj56Ihs2g Date: Mon, 2 Nov 2015 10:24:41 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C219F76F39@IRSMSX108.ger.corp.intel.com> References: <1446217733-9887-4-git-send-email-bernard.iremonger@intel.com> <2011896.kQSmzzuKMr@xps13> In-Reply-To: <2011896.kQSmzzuKMr@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 03/28] librte_ether: add function rte_eth_copy_dev_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 10:24:45 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Sunday, November 1, 2015 9:31 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 03/28] librte_ether: add function > rte_eth_copy_dev_info >=20 > 2015-10-30 15:08, Bernard Iremonger: > > +/** > > + * Copy pci device info to the Ethernet device data. > [...] > > +extern void rte_eth_copy_dev_info(struct rte_eth_dev *eth_dev, struct > rte_pci_device *pci_dev); >=20 > This function should have the word "pci" in its name. I will rename to rte_eth_copy_pci_info(). Regards, Bernard.