From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 243C68E81
 for <dev@dpdk.org>; Mon,  2 Nov 2015 11:35:33 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga101.jf.intel.com with ESMTP; 02 Nov 2015 02:35:33 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="840514422"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by orsmga002.jf.intel.com with ESMTP; 02 Nov 2015 02:35:32 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.229]) with mapi id 14.03.0248.002;
 Mon, 2 Nov 2015 10:33:28 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
 rte_pci_driver to rte_eth_dev_data
Thread-Index: AQHRFO4AZX+PM6tUz0GbZHUpEC9x/J6IiLMw
Date: Mon, 2 Nov 2015 10:33:27 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F76F6B@IRSMSX108.ger.corp.intel.com>
References: <1446217733-9887-3-git-send-email-bernard.iremonger@intel.com>
 <3062831.ssDunZgDdU@xps13>
In-Reply-To: <3062831.ssDunZgDdU@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
 rte_pci_driver to rte_eth_dev_data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 10:35:34 -0000

Hi Thomas,

<snip>

> Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
> rte_pci_driver to rte_eth_dev_data
>=20
> 2015-10-30 15:08, Bernard Iremonger:
> > +/** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO)
> */
> > +#define RTE_ETH_DEV_DRV_NEED_MAPPING
> RTE_PCI_DRV_NEED_MAPPING
> > +/** Device needs to be unbound even if no module is provided */
> > +#define RTE_ETH_DEV_DRV_FORCE_UNBIND
> RTE_PCI_DRV_FORCE_UNBIND
> > +/** Device supports link state interrupt */
> > +#define RTE_ETH_DEV_INTR_LSC   RTE_PCI_DRV_INTR_LSC
> > +/** Device  supports detaching capability */ #define
> > +RTE_ETH_DEV_DETACHABLE RTE_PCI_DRV_DETACHABLE
>=20
> Please, use an enum which has a name and can be referenced in the API, e.=
g.
> the variable X contains some X_flags.
> You should not try to re-use the same values as the PCI layer since it wi=
ll not
> be possible to map it forever when new buses will enter in the game.

I will use an enum  instead.

=20
> > +/** Device  is a bonded device */
> > +#define RTE_ETH_DEV_BONDED 0x0020
>=20
> Why not having RTE_ETH_DEV_PCAPED? ;)
> Please try to remove this flag.

I will remove this flag.

Regards,

Bernard.