From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 9F7805A6B
 for <dev@dpdk.org>; Fri,  6 Nov 2015 17:54:15 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga101.jf.intel.com with ESMTP; 06 Nov 2015 08:54:14 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,252,1444719600"; d="scan'208";a="829310225"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga001.fm.intel.com with ESMTP; 06 Nov 2015 08:54:08 -0800
Received: from irsmsx107.ger.corp.intel.com ([169.254.10.132]) by
 IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0248.002;
 Fri, 6 Nov 2015 16:54:07 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 1/1] librte_ether: fix coverity errors in
 rte_eth_copy_pci_info
Thread-Index: AQHRGLH3m0kUol6xX0eE6E69ASVE0J6PNZlA
Date: Fri, 6 Nov 2015 16:54:07 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F7DBB8@IRSMSX107.ger.corp.intel.com>
References: <1446827408-32393-1-git-send-email-bernard.iremonger@intel.com>
 <15745635.HYcjktu7yu@xps13>
In-Reply-To: <15745635.HYcjktu7yu@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] librte_ether: fix coverity errors in
 rte_eth_copy_pci_info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Nov 2015 16:54:16 -0000

Hi Thomas,
<snip>
> Subject: Re: [dpdk-dev] [PATCH 1/1] librte_ether: fix coverity errors in
> rte_eth_copy_pci_info
>=20
> 2015-11-06 16:30, Bernard Iremonger:
> > add else branch to if statement.
>=20
> I think a return statement would be more appropriate.
>=20
I will add return statement instead.

<snip>

Regards,

Bernard.