From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 85F4A58C3
 for <dev@dpdk.org>; Tue, 24 Nov 2015 17:29:03 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga101.jf.intel.com with ESMTP; 24 Nov 2015 08:29:03 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,338,1444719600"; 
   d="scan'208";a="1631370"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by fmsmga004.fm.intel.com with ESMTP; 24 Nov 2015 08:29:02 -0800
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 24 Nov 2015 16:29:01 +0000
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.223]) with mapi id 14.03.0248.002;
 Tue, 24 Nov 2015 16:29:00 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in
 pmd_ring_autotest
Thread-Index: AQHRJtMtu/L2+j+sm0u4OIo6gfyfo56rXEow
Date: Tue, 24 Nov 2015 16:29:00 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F8A77B@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1448292046-22682-1-git-send-email-bernard.iremonger@intel.com>
 <20151124161417.GA21112@bricha3-MOBL3>
In-Reply-To: <20151124161417.GA21112@bricha3-MOBL3>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in
 pmd_ring_autotest
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2015 16:29:03 -0000

Hi Bruce,

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, November 24, 2015 4:14 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in
> pmd_ring_autotest
>=20
> On Mon, Nov 23, 2015 at 03:20:46PM +0000, Bernard Iremonger wrote:
> > Use command line option --vdev=3Deth_ring0 to create port 0.
> > Create two rings and five ethdevs in test_pmd_ring for ports 1 to 5.
> > Improve test output by adding the port number to printf statements,
> > and adding a printf describing each test.
> >
> > revise ring-based PMD doc to match latest ring PMD code.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
>=20
> The doc changes are not relevant to the unit test fixes, so should be in =
a
> separate patch. The test changes themselves are good though, and actually
> makes the test runable without having to find a very specific command-lin=
e
> incantation to make things work right.
>=20
> Subject to this being split into two:
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Will I keep your ack on both patches when I split them?

Regards,

Bernard.

<snip>