From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id A951A58D8
 for <dev@dpdk.org>; Fri, 27 Nov 2015 17:40:24 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 27 Nov 2015 08:40:23 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,352,1444719600"; d="scan'208";a="848436987"
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])
 by fmsmga001.fm.intel.com with ESMTP; 27 Nov 2015 08:40:23 -0800
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 27 Nov 2015 16:40:22 +0000
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by
 IRSMSX156.ger.corp.intel.com ([169.254.3.110]) with mapi id 14.03.0248.002;
 Fri, 27 Nov 2015 16:40:22 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the
 ring_pmd_autotest program
Thread-Index: AQHRKS7QTiJguXGUBUuQ2k+P/VQm7p6wEZww
Date: Fri, 27 Nov 2015 16:40:21 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F8B689@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1448640460-25249-1-git-send-email-bernard.iremonger@intel.com>
 <1448640460-25249-2-git-send-email-bernard.iremonger@intel.com>
 <20151127161445.GB27472@bricha3-MOBL3>
In-Reply-To: <20151127161445.GB27472@bricha3-MOBL3>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the
 ring_pmd_autotest program
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Nov 2015 16:40:25 -0000

Hi Bruce,
<snip>

> Subject: Re: [dpdk-dev] [PATCH v3 1/2] app/test: fix failures in the
> ring_pmd_autotest program
>=20
> On Fri, Nov 27, 2015 at 04:07:39PM +0000, Bernard Iremonger wrote:
> > If eth_ring vdevs are created from the command line with the --vdev
> > option, they create there own rings which are not shared by other vdevs=
.
>=20
> Typo: s/their/there/

Will correct in v4.

>=20
> > Some of tests in this suite require that the vdevs share rings, so
> > some of the tests fail.
> >
> > For vdevs to share rings they must be created in the test code with
> > the
> > rte_eth_from_rings() function using rings created with the
> > rte_ring_create() function.
> >
> > Use the command line option --vdev=3Deth_ring0 to create port 0.
>=20
> As I understand it, this option is not mandatory for the tests to pass, i=
t only
> allows some additional functional tests on cmd-line created rings to be r=
un.
> This should perhaps still be called out in the commit message.

I will add that this option is not mandatory to the commit message.

>=20
> > Create two rings and five ethdevs in test_pmd_ring.c for ports 1 to 5.
> "... and then use these to run the unit tests on the pmd ring functionali=
ty"
>=20
>=20
> > Improve test output by adding the port number to printf statements,
> > and adding a printf describing each test.
> >
>=20
> /Bruce

Regards,

Bernard.