From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 62EB28D88 for ; Thu, 10 Dec 2015 10:58:43 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 10 Dec 2015 01:58:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,407,1444719600"; d="scan'208";a="838344737" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga001.jf.intel.com with ESMTP; 10 Dec 2015 01:58:42 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by IRSMSX152.ger.corp.intel.com ([169.254.6.143]) with mapi id 14.03.0248.002; Thu, 10 Dec 2015 09:58:40 +0000 From: "Iremonger, Bernard" To: Yuanhan Liu Thread-Topic: [dpdk-dev] [PATCH v2 1/1] doc: correct Vhost Sample Application guide Thread-Index: AQHRMxc16sl8M0sc20qcJ4VGubdvxJ7D+jdQ Date: Thu, 10 Dec 2015 09:58:40 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C219F8EC44@IRSMSX108.ger.corp.intel.com> References: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com> <1449681518-27656-1-git-send-email-bernard.iremonger@intel.com> <20151210065247.GT29571@yliu-dev.sh.intel.com> In-Reply-To: <20151210065247.GT29571@yliu-dev.sh.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/1] doc: correct Vhost Sample Application guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2015 09:58:43 -0000 Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Thursday, December 10, 2015 6:53 AM > To: Iremonger, Bernard > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/1] doc: correct Vhost Sample > Application guide >=20 > On Wed, Dec 09, 2015 at 05:18:38PM +0000, Bernard Iremonger wrote: > > correct sample console commands >=20 > You'd state what exactly this patch corrects here, and why is that needed= . I will add more information to the commit message. =20 > > > > changes in v2: > > remove "user@target:~$" prefixes in command lines. > > use continuation character to stay within 80 character limit. > > wrap sample python code. > > > > Fixes: d0dff9ba445e ("doc: sample application user guide" > > Fixes: 9bc23cb8209c ("doc: add vhost-user to sample guide") > > Fixes: 43866bf71d58 ("doc: fix vhost sample parameter") > > Signed-off-by: Bernard Iremonger > > --- > ... > > > > @@ -386,13 +386,15 @@ Running the Sample Code > > > > .. code-block:: console > > > > - user@target:~$ ./build/app/vhost-switch -c f -n 4 --huge-dir / > mnt/huge -- -p 0x1 --dev-basename usvhost > > + ./vhost-switch -c f -n 4 --socket-mem 1024 --huge-dir /mnt/hug= e \ > > + -- -p 0x1 --dev-basename usvhost >=20 > I don't think that's a right "correction": vhost-swtich would fail to > start: >=20 > EAL: Error - exiting with code: 1 > Cause: Cannot create mbuf pool >=20 > As vhost-switch creates more mbuf than 1024M can hold. >=20 > However, I do think that adding this option is necessary, otherwise, all > hugepages will be allocated to vhost-switch, leaving no memory for starti= ng > VM at all. (And this is kind of informatin you need to put into commit lo= g). >=20 > And limiting it to "1024M" is reasonable as well, so that we can run it o= n a > desktop (or laptop) without too many memories. You just need fix vhost- > switch example to not allocate too many mbufs by default. >=20 > --yliu Yes the --socket-mem option is necessary. =20 I will add a note that a value of may need to be greater than 102= 4. I will submit a patch to vhost-switch to reduce the number of mbufs. Regards, Bernard.