From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 83351567E
 for <dev@dpdk.org>; Thu, 10 Dec 2015 14:26:17 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 10 Dec 2015 05:26:16 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,408,1444719600"; d="scan'208";a="870863612"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by fmsmga002.fm.intel.com with ESMTP; 10 Dec 2015 05:26:15 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.13]) with mapi id 14.03.0248.002;
 Thu, 10 Dec 2015 13:26:14 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Thread-Topic: [PATCH] examples/vhost: reduce number of hugepages needed
Thread-Index: AQHRM0UTs8U+AKP56EquH3ALTB4utJ7ELpaAgAAGu2A=
Date: Thu, 10 Dec 2015 13:26:14 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F8ED41@IRSMSX108.ger.corp.intel.com>
References: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com>
 <20151210125911.GV29571@yliu-dev.sh.intel.com>
In-Reply-To: <20151210125911.GV29571@yliu-dev.sh.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: reduce number of hugepages
	needed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2015 13:26:17 -0000

Hi Yuanhan,

<snip>

> >  /*-
> >   *   BSD LICENSE
> >   *
> > - *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> > + *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> >   *   All rights reserved.
> >   *
> >   *   Redistribution and use in source and binary forms, with or withou=
t
> > @@ -53,7 +53,8 @@
> >
> >  #include "main.h"
> >
> > -#define MAX_QUEUES 512
> > +/* decrease MAX_QUEUES from 512 to reduce number of hugepages
> needed
> > +*/
>=20
> Minor nit: I would suggest to simply remove this comment, which might be =
a
> bit confusing without the content (that 512 would let vhost-switch fail t=
o start
> if given memory is small).
>=20
> Otherwise, this patch looks good to me.
>=20
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>=20
> Thanks.
>=20
> 	--yliu
>=20
<snip>

I will remove the comment.
Can I keep your ack.

Regards,

Bernard.