From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id D0E2A8E58
 for <dev@dpdk.org>; Thu, 10 Dec 2015 16:43:53 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga103.jf.intel.com with ESMTP; 10 Dec 2015 07:43:21 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,408,1444719600"; d="scan'208";a="868910669"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga002.jf.intel.com with ESMTP; 10 Dec 2015 07:43:21 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.138]) with mapi id 14.03.0248.002;
 Thu, 10 Dec 2015 15:43:20 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of
 hugepages	needed
Thread-Index: AQHRM1oesAtqzh117U+hqG6hlMb/rJ7EWzrg
Date: Thu, 10 Dec 2015 15:43:19 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F8EDAA@IRSMSX108.ger.corp.intel.com>
References: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com>
 <1449755601-25670-1-git-send-email-bernard.iremonger@intel.com>
 <2601191342CEEE43887BDE71AB97725836AD25A2@irsmsx105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB97725836AD25A2@irsmsx105.ger.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of
 hugepages	needed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2015 15:43:54 -0000

Hi Konstantin,

<snip>

> > Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of
> > hugepages needed
> >
> > Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages
> > required by the vhost-switch program.
> >
> > Changes in v2:
> > remove comment added before #define MAX_QUEUES in v1 patch.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>=20
>=20
> Wasn't it increased a while ago, because someone complained that
> 128 queues might not be enough on FVL?
> From git log I can see that it was first increased from 128 to 256, then =
from
> 256 to 512.
> The reason mentioned - HW that has bigger number of queues.
> Isn't it not the case anymore?
> If yes, why?
>=20
> BTW, shouldn't it be then at least:
>=20
> +#ifndef MAX_QUEUES
> +#define MAX_QUEUES 128
> +#endif
>=20
> So people can just do -D MAX_QUEUES=3DX at build time if they like(need) =
to.
> Konstantin
>=20
<snip>

I will add #ifndef MAX_QUEUES and #endif.

Regards,

Bernard.