DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config: add default linux configuration
Date: Wed, 17 Feb 2016 10:42:44 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C219FB275F@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20160216120849.GA8063@sivlogin002.ir.intel.com>

Hi Thomas,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, February 16, 2016 12:09 PM
> To: Thomas Monjalon <thomas.monjalon@6wind.com>
> Cc: dev@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] config: add default linux configuration
> 
> On Tue, Feb 16, 2016 at 12:23:12PM +0100, Thomas Monjalon wrote:
> > 2016-02-16 11:16, Ferruh Yigit:
> > > On Thu, Jan 28, 2016 at 02:31:45PM +0000, Bernard Iremonger wrote:
> > > > add config/defconfig_x86_64-default-linuxapp-gcc file.
> > > >
> > > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > >
> > > Apart from configuration related discussion, this patch was helpful
> > > for me to notice "default" machine type, and difference between
> > > "native", so I believe it is good to have this as sample config.
> >
> > The justification is strange. We are not going to have a config file
> > for every combinations.
> >
> Simply I found useful for me and thought others can be useful too, if you
> think not useful, that is OK, and yes probably we shouldn't have a sample for
> every combination and this patch is not suggesting that.
> 
> > Defaulting defconfig files to the native machine natural to me.
> >
> No issue on having native machine type, just another defconfig with another
> machine type.

The default config is useful when working with VM's, that is why I would like to add it.
I don't think it is necessary to add default configs for all the compilers, one sample should be enough.

> 
> > > Also not scope of this patch but I agree on Bruce's comment on
> > > renaming "default" machine type to "generic", I can send a patch for this
> if there is a demand.
> >
> > default is an Intel core 2. Why generic is a better name?
> 
> When you have "x86_64-default-linuxapp-icc", this feels like this is default
> configuration for given architecture among others, which will give best
> performance (what native suggests) If I would know nothing about DPDK and
> see available configs first time, I would pick this one, because this is default
> one J.
> 
> "generic" stress more that this config supports generic features of different
> machine types.
> 
> But this is how I feel, as I said I would prefer "generic", but I can survive with
> existing one.
> 
> Thanks,
> Ferruh

Regards,

Bernard.

      reply	other threads:[~2016-02-17 10:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 14:31 Bernard Iremonger
2016-02-12 12:31 ` Panu Matilainen
2016-02-12 15:04   ` Thomas Monjalon
2016-02-12 16:59     ` Ferruh Yigit
2016-02-12 17:13       ` Thomas Monjalon
2016-02-12 17:23         ` Ferruh Yigit
2016-02-16 11:16 ` Ferruh Yigit
2016-02-16 11:23   ` Thomas Monjalon
2016-02-16 12:08     ` Ferruh Yigit
2016-02-17 10:42       ` Iremonger, Bernard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C219FB275F@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).