From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3166BC34E for ; Wed, 17 Feb 2016 11:42:58 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 17 Feb 2016 02:42:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,459,1449561600"; d="scan'208";a="49363624" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga004.fm.intel.com with ESMTP; 17 Feb 2016 02:42:56 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.102]) by IRSMSX107.ger.corp.intel.com ([163.33.3.99]) with mapi id 14.03.0248.002; Wed, 17 Feb 2016 10:42:44 +0000 From: "Iremonger, Bernard" To: "Yigit, Ferruh" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] config: add default linux configuration Thread-Index: AQHRaLLL28oMxv99S0WNdDSaT5U4pZ8wDROA Date: Wed, 17 Feb 2016 10:42:44 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C219FB275F@IRSMSX108.ger.corp.intel.com> References: <1453991505-15205-1-git-send-email-bernard.iremonger@intel.com> <20160216111635.GA930@sivlogin002.ir.intel.com> <2202345.QkgQ4lTT1r@xps13> <20160216120849.GA8063@sivlogin002.ir.intel.com> In-Reply-To: <20160216120849.GA8063@sivlogin002.ir.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDhhZTRkZDYtNzk2OS00NzM3LTllZjUtODNhNDYyYmNmYmJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRYcm9RXC9PKzBLRGJOeGVhN0kxMW5nUUlpc0o1bFJmTms4SXhhVzdaMTM0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] config: add default linux configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2016 10:42:58 -0000 Hi Thomas, > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, February 16, 2016 12:09 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH] config: add default linux configuration >=20 > On Tue, Feb 16, 2016 at 12:23:12PM +0100, Thomas Monjalon wrote: > > 2016-02-16 11:16, Ferruh Yigit: > > > On Thu, Jan 28, 2016 at 02:31:45PM +0000, Bernard Iremonger wrote: > > > > add config/defconfig_x86_64-default-linuxapp-gcc file. > > > > > > > > Signed-off-by: Bernard Iremonger > > > > > > Apart from configuration related discussion, this patch was helpful > > > for me to notice "default" machine type, and difference between > > > "native", so I believe it is good to have this as sample config. > > > > The justification is strange. We are not going to have a config file > > for every combinations. > > > Simply I found useful for me and thought others can be useful too, if you > think not useful, that is OK, and yes probably we shouldn't have a sample= for > every combination and this patch is not suggesting that. >=20 > > Defaulting defconfig files to the native machine natural to me. > > > No issue on having native machine type, just another defconfig with anoth= er > machine type. The default config is useful when working with VM's, that is why I would li= ke to add it. I don't think it is necessary to add default configs for all the compilers,= one sample should be enough. >=20 > > > Also not scope of this patch but I agree on Bruce's comment on > > > renaming "default" machine type to "generic", I can send a patch for = this > if there is a demand. > > > > default is an Intel core 2. Why generic is a better name? >=20 > When you have "x86_64-default-linuxapp-icc", this feels like this is defa= ult > configuration for given architecture among others, which will give best > performance (what native suggests) If I would know nothing about DPDK and > see available configs first time, I would pick this one, because this is = default > one J. >=20 > "generic" stress more that this config supports generic features of diffe= rent > machine types. >=20 > But this is how I feel, as I said I would prefer "generic", but I can sur= vive with > existing one. >=20 > Thanks, > Ferruh Regards, Bernard.