From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B171E1396 for ; Fri, 27 May 2016 12:23:52 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 27 May 2016 03:23:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,373,1459839600"; d="scan'208";a="815993752" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 27 May 2016 03:23:49 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 27 May 2016 11:23:48 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by irsmsx155.ger.corp.intel.com ([169.254.14.34]) with mapi id 14.03.0248.002; Fri, 27 May 2016 11:23:48 +0100 From: "Iremonger, Bernard" To: David Marchand , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "viktorin@rehivetech.com" Thread-Topic: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver Thread-Index: AQHRmvoLG6QTjDF9VkSwV+mL7okW6p/MzU3w Date: Fri, 27 May 2016 10:23:47 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A010557@IRSMSX108.ger.corp.intel.com> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1461152657-19969-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1461152657-19969-1-git-send-email-david.marchand@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2NlMGM2MDktYmFkNC00MzE0LWIxNTItN2JhOWNmNjgxZGQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJNaEY0R2tpWFwvSHlIOGJsbnl6SzJFU1hncnprUnNRQ2Exa0RWMm5yaDRVPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 10:23:53 -0000 Hi David, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand > Sent: Wednesday, April 20, 2016 12:44 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; viktorin@rehivetech.com > Subject: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver >=20 > Following discussions with Jan [1] and some cleanup I started on pci code= , > here is a patchset that reworks pdev drivers registration and hotplug api= . >=20 > The structures changes mentioned in [1] are still to be done, but at leas= t, I > think we are one step closer to it. >=20 > Before this patchset, rte_driver .init semantics differed whether it conc= erned > a pdev or a vdev driver: > - for vdev, it actually meant that a devargs is given to the driver so > that it creates ethdev / crypto objects, so it was a probing action > - for pdev, it only registered the driver triggering no ethdev / crypto > objects >=20 > From my pov, eal hotplug api introduced in this patchset still needs more > work so that it does not need to know about devargs. So a new devargs api= is > needed. >=20 > Changes since v1: > - rebased on HEAD, new drivers should be okay > - patches have been split into smaller pieces > - RTE_INIT macro has been added, but in the end, I am not sure it is usef= ul > - device type has been removed from ethdev, as it was used only by hotplu= g > - getting rid of pmd type in eal patch (patch 5 of initial series) has be= en > dropped for now, we can do this once vdev drivers have been converted >=20 > [1] http://dpdk.org/ml/archives/dev/2016-January/031390.html >=20 > Regards, > -- > David Marchand >=20 > David Marchand (17): > pci: no need for dynamic tailq init > crypto: no need for a crypto pmd type > drivers: align pci driver definitions > eal: remove duplicate function declaration > eal: introduce init macros > crypto: export init/uninit common wrappers for pci drivers > ethdev: export init/uninit common wrappers for pci drivers > drivers: convert all pdev drivers as pci drivers > crypto: get rid of crypto driver register callback > ethdev: get rid of eth driver register callback > eal/linux: move back interrupt thread init before setting affinity > pci: add a helper for device name > pci: add a helper to update a device > ethdev: do not scan all pci devices on attach > eal: add hotplug operations for pci and vdev > ethdev: convert to eal hotplug > ethdev: get rid of device type >=20 > app/test/virtual_pmd.c | 2 +- > drivers/crypto/qat/rte_qat_cryptodev.c | 18 +- > drivers/net/af_packet/rte_eth_af_packet.c | 2 +- > drivers/net/bnx2x/bnx2x_ethdev.c | 35 +-- > drivers/net/bonding/rte_eth_bond_api.c | 2 +- > drivers/net/cxgbe/cxgbe_ethdev.c | 24 +- > drivers/net/cxgbe/cxgbe_main.c | 2 +- > drivers/net/e1000/em_ethdev.c | 16 +- > drivers/net/e1000/igb_ethdev.c | 40 +-- > drivers/net/ena/ena_ethdev.c | 20 +- > drivers/net/enic/enic_ethdev.c | 23 +- > drivers/net/fm10k/fm10k_ethdev.c | 23 +- > drivers/net/i40e/i40e_ethdev.c | 26 +- > drivers/net/i40e/i40e_ethdev_vf.c | 25 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 47 +--- > drivers/net/mlx4/mlx4.c | 22 +- > drivers/net/mlx5/mlx5.c | 21 +- > drivers/net/mpipe/mpipe_tilegx.c | 2 +- > drivers/net/nfp/nfp_net.c | 23 +- > drivers/net/null/rte_eth_null.c | 2 +- > drivers/net/pcap/rte_eth_pcap.c | 2 +- > drivers/net/ring/rte_eth_ring.c | 2 +- > drivers/net/szedata2/rte_eth_szedata2.c | 25 +- > drivers/net/vhost/rte_eth_vhost.c | 2 +- > drivers/net/virtio/virtio_ethdev.c | 26 +- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 +- > drivers/net/xenvirt/rte_eth_xenvirt.c | 2 +- > examples/ip_pipeline/init.c | 22 -- > lib/librte_cryptodev/rte_cryptodev.c | 67 +---- > lib/librte_cryptodev/rte_cryptodev.h | 2 - > lib/librte_cryptodev/rte_cryptodev_pmd.h | 45 +--- > lib/librte_cryptodev/rte_cryptodev_version.map | 9 +- > lib/librte_eal/bsdapp/eal/eal_pci.c | 52 +++- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 8 + > lib/librte_eal/common/eal_common_dev.c | 39 +++ > lib/librte_eal/common/eal_common_pci.c | 17 +- > lib/librte_eal/common/eal_private.h | 20 +- > lib/librte_eal/common/include/rte_dev.h | 29 ++- > lib/librte_eal/common/include/rte_eal.h | 3 + > lib/librte_eal/common/include/rte_pci.h | 32 +++ > lib/librte_eal/common/include/rte_tailq.h | 4 +- > lib/librte_eal/linuxapp/eal/eal.c | 7 +- > lib/librte_eal/linuxapp/eal/eal_pci.c | 16 +- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 8 + > lib/librte_ether/rte_ethdev.c | 316 ++++--------------= ------ > lib/librte_ether/rte_ethdev.h | 40 ++- > lib/librte_ether/rte_ether_version.map | 9 +- > 47 files changed, 392 insertions(+), 810 deletions(-) >=20 > -- > 1.9.1 Patches 3,8,16 and 17 no longer apply to the latest master branch. A rebase is needed. Regards, Bernard. =20