From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 502F4591F for ; Tue, 14 Jun 2016 11:18:31 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 14 Jun 2016 02:18:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="827689419" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga003.jf.intel.com with ESMTP; 14 Jun 2016 02:18:30 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by IRSMSX103.ger.corp.intel.com ([169.254.3.240]) with mapi id 14.03.0248.002; Tue, 14 Jun 2016 10:18:28 +0100 From: "Iremonger, Bernard" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display Thread-Index: AQHRxL5jsYP40vrTQ0mYbdBT6YHqlZ/nflMAgAAS8ZCAAR9bQA== Date: Tue, 14 Jun 2016 09:18:27 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A039066@IRSMSX108.ger.corp.intel.com> References: <1462462795-18767-1-git-send-email-bernard.iremonger@intel.com> <1465744997-15487-1-git-send-email-bernard.iremonger@intel.com> <1465744997-15487-5-git-send-email-bernard.iremonger@intel.com> <8CEF83825BEC744B83065625E567D7C21A038DFF@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A038DFF@IRSMSX108.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTkyM2I3MDAtMDhjNi00NTM4LWI1MGMtYmMyZTY2OTlhMmRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZZb1wvTHM2N2dySnZndlhUUXN1TDZXVDQ2NHgrZlh4dlE4dzJMT0tVNjdvPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 09:18:31 -0000 Hi Pablo, > > > Subject: [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from > > > fwd_config_display > > > > > > Remove fwd_config_setup from fwd_config_display and check that > > > forwarding has been setup before displaying forwarding configuration. > > > Add call to fwd_config_setup for corelist, coremask, nbcore setup. > > > Add call to fwd_config_setup for portlist, portmask, nbport setup. > > > > Probably we need to add that call to the commands that change number > > of RX/TX queues, as well. >=20 > I will check this. Should fwd_config_setup be added for the --rxd and --txd options as well= ? =20 > > > Signed-off-by: Bernard Iremonger > > > --- > > > app/test-pmd/cmdline.c | 23 ++++++++++++++++------- > > > app/test-pmd/config.c | 6 ++++-- > > > 2 files changed, 20 insertions(+), 9 deletions(-) > > > > > > > [...] > > > > > --- a/app/test-pmd/config.c > > > +++ b/app/test-pmd/config.c > > > @@ -1424,8 +1424,10 @@ pkt_fwd_config_display(struct fwd_config > > > *cfg) void > > > fwd_config_display(void) > > > { > > > - fwd_config_setup(); > > > - pkt_fwd_config_display(&cur_fwd_config); > > > + if (cur_fwd_config.nb_fwd_ports) > > > + pkt_fwd_config_display(&cur_fwd_config); > > > + else > > > + printf("Please set portlist first\n"); > > > > I think this is not necessary. I would call fwd_config_setup() at > > startup, so everything is setup when this is called (even if it is the > > first command when the prompt comes up). > > I think at the end of init_config() is a good place. >=20 > Ok, I will try this. Yes, this works. Regards, Bernard.