From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4FBC7961B
 for <dev@dpdk.org>; Tue, 14 Jun 2016 16:14:23 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 14 Jun 2016 07:14:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="975406703"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by orsmga001.jf.intel.com with ESMTP; 14 Jun 2016 07:14:19 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.151]) with mapi id 14.03.0248.002;
 Tue, 14 Jun 2016 15:14:18 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from
 fwd_config_display
Thread-Index: AQHRxjhPnvK9LSxUzkqZZF4eabvisJ/o3E2AgAAiyUA=
Date: Tue, 14 Jun 2016 14:14:17 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C21A0394D5@IRSMSX108.ger.corp.intel.com>
References: <1465744997-15487-1-git-send-email-bernard.iremonger@intel.com>
 <1465907296-27117-1-git-send-email-bernard.iremonger@intel.com>
 <1465907296-27117-5-git-send-email-bernard.iremonger@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C9608B6@IRSMSX108.ger.corp.intel.com>
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C9608B6@IRSMSX108.ger.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjlhNDg1MWQtNDYyNi00YzI2LTkyN2UtMDBlYWNhNjQ1ZmY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZuOXI5YlZabVRlMTBRdUZ1QmhHMXJTWWJFVWN1VEZGSE9NTlFsK1FCbnM9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 4/9] app/testpmd: remove fwd_config_setup
 from fwd_config_display
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jun 2016 14:14:23 -0000

Hi Pablo,

<snip>

> > Subject: [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from
> > fwd_config_display
> >
> > Add call to fwd_config_setup to init_config.
> > Remove fwd_config_setup from fwd_config_display.
> > Add call to fwd_config_setup for corelist, coremask and nbcore setup.
> > Add call to fwd_config_setup for portlist, portmask and nbport setup.
> > Add call to fwd_config_setup for rxq, txq, rxd and txd setup.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
>=20
> Apologies for misleading here, but I think we should drop this patch for =
the
> moment.
> It is conflicting with another patch and it is not really necessary for y=
our
> changes (am I right here?), so I would say best thing to do is to drop it=
 and
> discuss if we want this change separately.

This patch is needed for the patchset and should not be dropped.

Is it conflicting with patch the following patch?

http://dpdk.org/dev/patchwork/patch/13132/

This patch is renaming fwd_config_display to fwd_config_setup_display.
It clarifies what the function is doing, but does not address the issue of =
separating the setup from the display.

Separating the setup from the display is resolved in my patch.

Regards,

Bernard.