From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8AC852904 for ; Thu, 15 Sep 2016 18:47:04 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 15 Sep 2016 09:46:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,339,1470726000"; d="scan'208";a="1030701332" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga001.jf.intel.com with ESMTP; 15 Sep 2016 09:46:41 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX101.ger.corp.intel.com ([169.254.1.135]) with mapi id 14.03.0248.002; Thu, 15 Sep 2016 17:46:39 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "dev@dpdk.org" , Jerin Jacob , "Shah, Rahul R" , "Lu, Wenzhuo" , azelezniak Thread-Topic: [dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management Thread-Index: AQHR/3nL92Tihh00JUigC2GSiYccqaBxO5UAgATmckCAAQ+CAIADl+fw Date: Thu, 15 Sep 2016 16:46:38 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A08123A@IRSMSX108.ger.corp.intel.com> References: <1471528125-26357-1-git-send-email-bernard.iremonger@intel.com> <20160909142251.GB4100@localhost.localdomain> <8CEF83825BEC744B83065625E567D7C21A0761A7@IRSMSX108.ger.corp.intel.com> <1616711.yO3pyfy9gD@xps13> In-Reply-To: <1616711.yO3pyfy9gD@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDMyYzllYTctYjgyMy00NWY5LWFhZjItZWRmOTFmN2YyNGE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiI5TkhleXhXdVNvaGJMUEtESkhFSXhkSjdPdE1GVXplVkJvOEx3U1BhWWJjPSJ9 x-ctpclassification: CTP_PUBLIC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2016 16:47:05 -0000 Hi Thomas, > Subject: Re: [dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF > management >=20 > 2016-09-12 16:28, Iremonger, Bernard: > > > On Fri, Aug 26, 2016 at 10:10:18AM +0100, Bernard Iremonger wrote: > > > > Add new API functions to configure and manage VF's on a NIC. > > > > > > > > add rte_eth_dev_vf_ping function. > > > > add rte_eth_dev_set_vf_vlan_anti_spoof function. > > > > add rte_eth_dev_set_vf_mac_anti_spoof function. > > > > > > > > Signed-off-by: azelezniak > > > > > > > > add rte_eth_dev_set_vf_vlan_strip function. > > > > add rte_eth_dev_set_vf_vlan_insert function. > > > > add rte_eth_dev_set_loopback function. > > > > add rte_eth_dev_set_all_queues_drop function. > > > > add rte_eth_dev_set_vf_split_drop_en function add > > > > rte_eth_dev_set_vf_mac_addr function. > > > > > > Do we really need to expose VF specific functions here? > > > It can be generic(PF/VF) function indexed only through port_id. > > > (example: as rte_eth_dev_set_vlan_anti_spoof(uint8_t port_id, > > > uint8_t on)) For instance, In Thunderx PMD, We are not exposing a > > > separate port_id for PF. We only enumerate 0..N VFs as 0..N ethdev > > > port_id > > > > Our intention with this patch is to control the VF from the PF. > > > > The following librte_ether functions already work in a similar way: > > > > rte_eth_dev_set_vf_rxmode(uint8_t port_id, uint16_t vf, uint16_t > > rx_mode, uint8_t on) > > > > rte_eth_dev_set_vf_rx(uint8_t port_id, uint16_t vf, uint8_t on) > > > > rte_eth_dev_set_vf_tx(uint8_t port_id, uint16_t vf, uint8_t on) > > > > int rte_eth_set_vf_rate_limit(uint8_t port_id, uint16_t vf, uint16_t > > tx_rate, uint64_t q_msk) >=20 > I have a bad feeling with these functions dedicated to VF from PF. > Are we sure there is no other way? > I mean we just need to know the VF with a port ID. When the VF is used in a VM the port ID of the VF is not visible to the PF. I don't think there is another way to do this. Regards, Bernard.