From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EF3E12B88 for ; Thu, 29 Sep 2016 17:16:51 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 29 Sep 2016 08:16:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,415,1470726000"; d="scan'208";a="1058319739" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga002.jf.intel.com with ESMTP; 29 Sep 2016 08:16:50 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Sep 2016 16:16:48 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX156.ger.corp.intel.com ([169.254.3.80]) with mapi id 14.03.0248.002; Thu, 29 Sep 2016 16:16:48 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "dev@dpdk.org" , "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , azelezniak Thread-Topic: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management Thread-Index: AQHSGlwgGOr6Jz8F2E+iSNVDeLebLqCQdnWAgAAWzcA= Date: Thu, 29 Sep 2016 15:16:48 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A08E0CA@IRSMSX108.ger.corp.intel.com> References: <1474453204-31516-1-git-send-email-bernard.iremonger@intel.com> <1475158591-2243-2-git-send-email-bernard.iremonger@intel.com> <3631809.sFy4WKcCTS@xps13> In-Reply-To: <3631809.sFy4WKcCTS@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWNjODYwZjItMTU3Zi00MTAyLThiZjItOTlhMDc2NDU5MjYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJWNGdFTkZpRHZHcmVWaCtSMTk4YUswVk5DS1IzSGhOT3l2QjQzUUN4aEU9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 15:16:52 -0000 Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF > management >=20 > 2016-09-29 15:16, Bernard Iremonger: > > Add new API function to configure and manage VF's on a NIC. > > > > add rte_eth_dev_set_vf_vlan_stripq function. > > > > Signed-off-by: azelezniak >=20 > We need the full name of azelezniak. It is Alex Zelezniak, I will update the commit messages. > > Signed-off-by: Bernard Iremonger > [...] > > +int > > +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int on); >=20 > Why keeping this function in ethdev? This function is using an existing API in the eth_dev_ops structure. dev->dev_ops->vlan_strip_queue_set The vlan_strip_queue_set API is used by the i40e, ixgbe and mlx5 PMD's. > I think it would be more consistent to have also existing VF functions mo= ving > from ethdev to rte_pmd_ixgbe.h. > You cannot remove them, but you can create their ixgbe-specific version a= nd > announce that the ethdev ones are deprecated. There are 5 existing VF functions which are only used by ixgbe PMD at prese= nt. It would make sense to create ixgbe-specific versions, however I think this= should be done in a separate patchset. Regards, Bernard =20