From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 1BCC1558C
 for <dev@dpdk.org>; Thu,  6 Oct 2016 17:46:48 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga104.jf.intel.com with ESMTP; 06 Oct 2016 08:46:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,454,1473145200"; d="scan'208";a="769599790"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by FMSMGA003.fm.intel.com with ESMTP; 06 Oct 2016 08:46:48 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.6]) with mapi id 14.03.0248.002;
 Thu, 6 Oct 2016 16:45:54 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Shah, Rahul R" <rahul.r.shah@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "az5157@att.com" <az5157@att.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Thread-Topic: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal
 callback function
Thread-Index: AQHSH8SD2FeiVD24+EqwRkAkHVUdGaCbUbEAgAAo32D///jLgIAAGA+w///0fQCAABFhcA==
Date: Thu, 6 Oct 2016 15:45:53 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C21A08F910@IRSMSX108.ger.corp.intel.com>
References: <1475592734-22355-1-git-send-email-bernard.iremonger@intel.com>
 <1884200.vdWHEKFaxn@xps13>
 <8CEF83825BEC744B83065625E567D7C21A08F8EF@IRSMSX108.ger.corp.intel.com>
 <4741428.MAME74GNI7@xps13>
In-Reply-To: <4741428.MAME74GNI7@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmRmMmJmNGUtOWJhNy00OWM3LWExYzItMDc3ZGYyYjMzZTkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ild6UHlXMlRmSXJQNW1sUm5cL0RweGxMRkZBOUdLbXhZQzZIR0ZyejNtSW53PSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal
 callback function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2016 15:46:49 -0000

Hi Thomas,

> Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal
> callback function
>=20
> 2016-10-06 15:32, Iremonger, Bernard:
> > > > > 2016-10-06 12:26, Bernard Iremonger:
> > > > > >  void
> > > > > >  _rte_eth_dev_callback_process(struct rte_eth_dev *dev,
> > > > > > -	enum rte_eth_event_type event)
> > > > > > +	enum rte_eth_event_type event, void *param)
> > > > >
> > > > > You need to squash the patches updating the calls to this functio=
n.
> > > > > Otherwise, this patch does not compile.
> > > >
> > > > I will have to squash everything into one patch, separate patches
> > > > will not
> > > compile.
> > >
> > > No you can keep a separate patch for the VF event in ixgbe.
> >
> > I have 4 patches at present
> >
> > librte_ether
> > net/ixgbe
> > drivers/net
> > app/test
> >
> > Would this be acceptable or do you just want  everything squashed into
> librte_ether except for net/ixgbe?
>=20
> You can test the compilation of each patch with this command:
> 	git rebase -i origin/master -x scripts/test-build.sh or just:
> 	git rebase -i origin/master -x make
>=20
> I think you need to squash drivers/net (adding just NULL param) and
> app/test in ethdev patch.

They do not compile if applied one by one.
Ok, I will squash drivers/net and app/test into the librte_ether patch.

Regards,

Bernard.