From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0C7FD37B4 for ; Fri, 7 Oct 2016 14:19:06 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 07 Oct 2016 05:19:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,308,1473145200"; d="scan'208";a="17221791" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga005.fm.intel.com with ESMTP; 07 Oct 2016 05:19:04 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002; Fri, 7 Oct 2016 13:19:03 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "dev@dpdk.org" , "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , "jerin.jacob@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCH v6 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg Thread-Index: AQHSH/GCyAxsbynqoEuqhYjYYK3FrKCc1+0AgAARlQA= Date: Fri, 7 Oct 2016 12:19:03 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A08FB5E@IRSMSX108.ger.corp.intel.com> References: <1475753191-17391-1-git-send-email-bernard.iremonger@intel.com> <1475772490-10491-3-git-send-email-bernard.iremonger@intel.com> <1717577.NEkDseq0hE@xps13> In-Reply-To: <1717577.NEkDseq0hE@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTA5ZDhlOWEtMDUzZS00ZjQwLWFkNDgtZjMyZWZmMmI4NzRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InBrOWI3YnpxYTJsNWZzclZSRnRsK0laa1hJcTkwT09TNmwzbDFaRGhVV289In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 12:19:07 -0000 Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v6 2/2] net/ixgbe: add callback to user ap= p > on VF to PF mbox msg >=20 > 2016-10-06 17:48, Bernard Iremonger: > > call _rte_eth_dev_callback_process from ixgbe_rcv_msg_from_vf > function. > > > > The callback asks the user application if it is allowed to perform the > > function. > > If the cb_param.retval is RTE_PMD_IXGBE_MB_EVENT_PROCEED then > > continue, if 0, do nothing and send ACK to VF if > 1, do nothing and > > send NAK to VF. > [...] > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -3559,7 +3559,7 @@ ixgbe_dev_interrupt_delayed_handler(void > *param) > > ixgbe_dev_link_update(dev, 0); > > intr->flags &=3D ~IXGBE_FLAG_NEED_LINK_UPDATE; > > ixgbe_dev_link_status_print(dev); > > - _rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_LSC); > > + _rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_LSC, NULL); > > } > > > > PMD_DRV_LOG(DEBUG, "enable intr in delayed handler S[%08x]", > eicr); > > @@ -7525,7 +7525,7 @@ static void ixgbevf_mbx_process(struct > > rte_eth_dev *dev) > > > > /* PF reset VF event */ > > if (in_msg =3D=3D IXGBE_PF_CONTROL_MSG) > > - _rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_RESET); > > + _rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_RESET, NULL); > > } >=20 > This piece should go into the patch 1. Ok, I will send a v7. Regards, Bernard.