From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7DEEB378B
 for <dev@dpdk.org>; Mon, 10 Oct 2016 16:31:32 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP; 10 Oct 2016 07:31:31 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,324,1473145200"; d="scan'208";a="1062827006"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by orsmga002.jf.intel.com with ESMTP; 10 Oct 2016 07:31:30 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.198]) with mapi id 14.03.0248.002;
 Mon, 10 Oct 2016 15:31:29 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Shah, Rahul R" <rahul.r.shah@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "az5157@att.com" <az5157@att.com>,
 "Iremonger, Bernard" <bernard.iremonger@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v7 2/2] net/ixgbe: add callback to user app
 on VF to PF mbox msg
Thread-Index: AQHSILpjY+7yO9xYsk68cfpGu1/9bKCdhnWAgAQ9CJA=
Date: Mon, 10 Oct 2016 14:31:29 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C21A090507@IRSMSX108.ger.corp.intel.com>
References: <1475772490-10491-1-git-send-email-bernard.iremonger@intel.com>
 <1475858784-5303-3-git-send-email-bernard.iremonger@intel.com>
 <2780407.hr2q20cLcS@xps13>
In-Reply-To: <2780407.hr2q20cLcS@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWZhYThiMjctMDM2Yi00OTZjLWFjMjQtNjE3ZGU1Yzg3ZGZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitjSDRWb3FUWlB6Q0F4d1F0U01KNURDYXFTWUdQY0tWdk1xaWJqcU1qbVk9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v7 2/2] net/ixgbe: add callback to user app
 on VF to PF mbox msg
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2016 14:31:33 -0000

Hi Thomas,

<snip>

> Subject: Re: [dpdk-dev] [PATCH v7 2/2] net/ixgbe: add callback to user ap=
p
> on VF to PF mbox msg
>=20
> 2016-10-07 17:46, Bernard Iremonger:
> > +struct rte_pmd_ixgbe_mb_event_param {
> > +	uint16_t vfid;     /**< Virtual Function number */
> > +	uint16_t msg_type; /**< message type */
> > +	uint16_t retval;   /**< return value */
> > +	void *userdata;    /**< pointer to user data */
>=20
> Generally speaking, the user data is a pointer passed by the application =
when
> registering the callback and must be untouched.
> It should be the name of the parameter that you are overriding with this
> structure.
> So this "userdata" pointer could probably be better defined.
>=20
> By the way, it is far from trivial to understand how to write the callbac=
k.
> I think it deserves more explanations.
>=20

I will clarify the description of the struct  rte_pmd_ixgbe_mb_event_param,=
 and rename the member userdate to msg in a v8 patchset.

Regards,

Bernard.