From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 14DDC2C12
 for <dev@dpdk.org>; Wed, 12 Oct 2016 17:27:30 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga105.fm.intel.com with ESMTP; 12 Oct 2016 08:27:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,482,1473145200"; d="scan'208";a="18836654"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga006.fm.intel.com with ESMTP; 12 Oct 2016 08:27:25 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.198]) with mapi id 14.03.0248.002;
 Wed, 12 Oct 2016 16:27:24 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Shah, Rahul R" <rahul.r.shah@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "az5157@att.com" <az5157@att.com>, "De
 Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's
Thread-Index: AQHSJJnNKd6MU7oYd0WvkkRs/R5eyaCk2/OAgAAS2xA=
Date: Wed, 12 Oct 2016 15:27:23 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C21A092012@IRSMSX108.ger.corp.intel.com>
References: <1475858784-5303-1-git-send-email-bernard.iremonger@intel.com>
 <1476284596-30571-3-git-send-email-bernard.iremonger@intel.com>
 <2251153.ZmgGxBf8Fs@xps13>
In-Reply-To: <2251153.ZmgGxBf8Fs@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTUwZmU0YTYtOWM1YS00MTVmLTk3ZTYtMWUzMWIxNWI2MmJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNWeEdXNUhKTytsQ3ZkazBtWG1Ud0U3RFNFTFluRnV3TXptT0Fvb3NCNk09In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2016 15:27:31 -0000

Hi Thomas,

<snip>

> Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new
> API's
>=20
> 2016-10-12 16:03, Bernard Iremonger:
> > --- a/app/test-pmd/Makefile
> > +++ b/app/test-pmd/Makefile
> > @@ -58,6 +58,17 @@ SRCS-y +=3D csumonly.c  SRCS-y +=3D icmpecho.c
> >  SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) +=3D ieee1588fwd.c
> >
> > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
> > +LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D -lrte_pmd_ixgbe endif
> > +
> > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
> > +LDLIBS +=3D -lrte_pmd_ixgbe
> > +endif
> > +endif
>=20
> Sorry if I miss something, but I thought it was enough to do:
> LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D -lrte_pmd_ixgbe

No unfortunately not, the above line does not work for all scenarios .

There are 4 scenarios as follows:

CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dy  with CONFIG_RTE_BUILD_SHARED_LIB=3Dn

CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dy  with CONFIG_RTE_BUILD_SHARED_LIB=3Dy

CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dn  with CONFIG_RTE_BUILD_SHARED_LIB=3Dy

CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dn  with CONFIG_RTE_BUILD_SHARED_LIB=3Dn

I have been doing quite a bit of building today to get it to work in all 4 =
scenarios.

Regards,

Bernard.