From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1F4D62B8C for ; Wed, 12 Oct 2016 18:21:16 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 12 Oct 2016 09:21:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,336,1473145200"; d="scan'208";a="1043769623" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 12 Oct 2016 09:21:14 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 12 Oct 2016 17:21:13 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX156.ger.corp.intel.com ([169.254.3.80]) with mapi id 14.03.0248.002; Wed, 12 Oct 2016 17:21:13 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "dev@dpdk.org" , "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's Thread-Index: AQHSJJnNKd6MU7oYd0WvkkRs/R5eyaCk2/OAgAAS2xD///QWgIAAEk/g///2F4CAABNmgA== Date: Wed, 12 Oct 2016 16:21:12 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A092162@IRSMSX108.ger.corp.intel.com> References: <1475858784-5303-1-git-send-email-bernard.iremonger@intel.com> <2791430.Y8ncTCNxt5@xps13> <8CEF83825BEC744B83065625E567D7C21A09209C@IRSMSX108.ger.corp.intel.com> <4355552.XQIr0B1y70@xps13> In-Reply-To: <4355552.XQIr0B1y70@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWI4YTM1ODUtZjkxYS00NTAwLWI3NGMtOGI5NTI3ZTEyZWQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IllaaGh1TXFDeGRRaGJSR0xQZUphdnhhYzJBSk9vTnp3Y3VLXC9RSm1uTElNPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 16:21:17 -0000 Hi Thomas, > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests > > > > > for new API's > > > > > > > > > > 2016-10-12 16:03, Bernard Iremonger: > > > > > > --- a/app/test-pmd/Makefile > > > > > > +++ b/app/test-pmd/Makefile > > > > > > @@ -58,6 +58,17 @@ SRCS-y +=3D csumonly.c SRCS-y +=3D icmpecho= .c > > > > > > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) +=3D ieee1588fwd.c > > > > > > > > > > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) > > > > > > +LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D -lrte_pmd_ixgbe > > > endif > > > > > > + > > > > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > > > > > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > > > > > > +LDLIBS +=3D -lrte_pmd_ixgbe > > > > > > +endif > > > > > > +endif > > > > > > > > > > Sorry if I miss something, but I thought it was enough to do: > > > > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D -lrte_pmd_ixgbe > > > > > > > > No unfortunately not, the above line does not work for all scenario= s . > > > > > > > > There are 4 scenarios as follows: > > > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dy with > > > CONFIG_RTE_BUILD_SHARED_LIB=3Dn > > > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dy with > > > CONFIG_RTE_BUILD_SHARED_LIB=3Dy > > > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dn with > > > CONFIG_RTE_BUILD_SHARED_LIB=3Dy > > > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dn with > > > CONFIG_RTE_BUILD_SHARED_LIB=3Dn > > > > > > > > I have been doing quite a bit of building today to get it to work > > > > in all 4 > > > scenarios. > > > > > > I have a doubt about the tests because LDLIBS-y does not exist. > > > There is _LDLIBS-y and LDLIBS. > > > But in the static case, you wrote: > > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D -lrte_pmd_ixgbe > endif > > > Please could you check? > > > > LDLIBS-y exists in some of the scenarios but not all. >=20 > I think I'm something obvious. > Please could you point the line where LDLIBS-y is used? Line 62 of latest Makefile; LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D -lrte_pmd_ixgbe LDLIBS-y does not exist when CONFIG_RTE_BUILD_SHARED_LIB=3Dy =20 > > Do you want me to check the four scenarios with just the line below. > > > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D -lrte_pmd_ixgbe >=20 > Let's check the theory first :) Ok Regards, Bernard.