From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 2DEFB2A5E
 for <dev@dpdk.org>; Wed,  7 Dec 2016 18:00:14 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga104.fm.intel.com with ESMTP; 07 Dec 2016 09:00:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="14979683"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga002.jf.intel.com with ESMTP; 07 Dec 2016 09:00:10 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.159]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.52]) with mapi id 14.03.0248.002;
 Wed, 7 Dec 2016 17:00:10 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 26/32] app/testpmd: initialize receive
 mode for VMDq
Thread-Index: AQHSUDqaLmbzT3/ulEa9Fo6n+6mKqaD8lo2AgAAfCkA=
Date: Wed, 7 Dec 2016 17:00:09 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C224D05768@IRSMSX108.ger.corp.intel.com>
References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-27-git-send-email-wenzhuo.lu@intel.com>
 <1aa1ef1a-e823-8cc6-9b8f-06febdbd19ff@intel.com>
In-Reply-To: <1aa1ef1a-e823-8cc6-9b8f-06febdbd19ff@intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTk3NTFiMjctZmFmNC00NWUzLWI4NmEtYmQ2ZGI0ZWIwMTMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJhbVNHTDRDRmU2Y0Z2RklXdU9uYW4yd1hlcllZdWNxYTR2eGIrY0lsbUx3PSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 26/32] app/testpmd: initialize receive
 mode for VMDq
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2016 17:00:15 -0000

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 3:07 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 26/32] app/testpmd: initialize receive
> mode for VMDq
>=20
> On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:
> > Initialise VMDq in the init_port_config function in a similar way to
> > how it is done in the VMDq sample application.
>=20
> What is the effect of doing existing initialization?

This patch results in the function i40e_vmdq_setup() function being called =
 in i40e_ethdev.c at
Line 1307: ret =3D i40e_vmdq_setup(dev);

We are seeing unexpected side effects from this patch.=20
It will be dropped from the v3 of this patch set, pending further investiga=
tion.

Regards,

Bernard.