From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id DC10F3772
 for <dev@dpdk.org>; Fri,  9 Dec 2016 13:10:07 +0100 (CET)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga104.jf.intel.com with ESMTP; 09 Dec 2016 04:10:06 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="38529881"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by orsmga004.jf.intel.com with ESMTP; 09 Dec 2016 04:10:06 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.159]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.158]) with mapi id 14.03.0248.002;
 Fri, 9 Dec 2016 12:10:04 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v1 3/5] app/testpmd: add command for set VF
 VLAN filter
Thread-Index: AQHSUg9cWKQ4FSs0IkCFpdNxC655iqD/hCEAgAAB5YA=
Date: Fri, 9 Dec 2016 12:10:05 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C224D06066@IRSMSX108.ger.corp.intel.com>
References: <1481282878-26176-1-git-send-email-bernard.iremonger@intel.com>
 <1481282878-26176-4-git-send-email-bernard.iremonger@intel.com>
 <b1e6668c-8528-7cdd-c3ab-292a39f8722d@intel.com>
In-Reply-To: <b1e6668c-8528-7cdd-c3ab-292a39f8722d@intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDY3MmIyMDMtNGE5NS00OWJlLWE3ZDItNTkzMTA4YTEwZWNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJrcUppOHVucVdTcGd6eDFOWnR5eHIxTmFmQnRmVVJNTkFrSEVmMnBKbHIwPSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v1 3/5] app/testpmd: add command for set VF
 VLAN filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Dec 2016 12:10:08 -0000

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, December 9, 2016 12:03 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>;
> thomas.monjalon@6wind.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 3/5] app/testpmd: add command for set
> VF VLAN filter
>=20
> On 12/9/2016 11:27 AM, Bernard Iremonger wrote:
> > Add the following command to testpmd:
> > set vf vlan filter <port_id> <vlan_id> <vf_mask> <on|off>
> >
> > Add command to the testpmd user guide.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
>=20
> <...>
>=20
> > +
> > +cmdline_parse_inst_t cmd_set_vf_vlan_filter =3D {
> > +	.f =3D cmd_set_vf_vlan_filter_parsed,
> > +	.data =3D NULL,
> > +	.help_str =3D "set vf vlan filter <port_id> <vlan_id> <vf_mask>
> > +<on_off>",
>=20
> s/<on_off>/on|off
>=20
> Only variables should be wrapped with "<>", fixed string with options can=
 be
> used as a|b|c .
>=20
> similar issues in other testpmd patches.
>=20

I will fix in a v2.

Regards,

Bernard.