From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 446462E83 for ; Fri, 9 Dec 2016 14:23:40 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 09 Dec 2016 05:23:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="200827858" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga004.fm.intel.com with ESMTP; 09 Dec 2016 05:23:38 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.159]) by IRSMSX107.ger.corp.intel.com ([169.254.10.66]) with mapi id 14.03.0248.002; Fri, 9 Dec 2016 13:23:38 +0000 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions. Thread-Index: AQHSUg9VSuiSrpKTBUe1W+FFXPgUeqD/gdAAgAAAnGCAABMFAIAABEOw Date: Fri, 9 Dec 2016 13:23:38 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D060BD@IRSMSX108.ger.corp.intel.com> References: <1481282878-26176-1-git-send-email-bernard.iremonger@intel.com> <8CEF83825BEC744B83065625E567D7C224D0601D@IRSMSX108.ger.corp.intel.com> <29626520.OD9qkZZgkn@xps13> In-Reply-To: <29626520.OD9qkZZgkn@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjMyMTllYjEtMjVhOC00MDNhLTkyNzItNGU0ODZlMmYyYTNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiI5NU0rUmpYNHpVeHFhRnhhQW1UOTFKekx3WTFZY1hQanFJY1EzWGM4QkgwPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 13:23:41 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, December 9, 2016 1:05 PM > To: Iremonger, Bernard > Cc: Yigit, Ferruh ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions. >=20 > 2016-12-09 12:00, Iremonger, Bernard: > > From: Yigit, Ferruh > > > Why this patchset doesn't remove ethdev updates for these functions? > > > > > > ixgbe is the only user for these eth-dev_ops, since code moved to > > > ixgbe driver, they and relevant rte_eth_xx functions (and > > > deprecation notice) can be removed in this patchset. Most probably > > > after testpmd updated to prevent compilation errors. > > > > My understanding is that the functions should be copied and reworked > before being removed from the ethdev, and that the removal should be > done in a separate patch set. > > > > Hi Thomas, > > > > Could you clarify please. >=20 > It was announced that these functions will be removed, so they can be saf= ely > removed in 17.02, right? Yes, it was announced in 16.11 that these functions will be removed so I be= lieve they can be safely removed in17.02. > In this case, it is a code move: copy, rework and delete in the same patc= h. > And yes, the deprecation notice must be removed at the same time. I will add the deletes in a v2 of the patchset. Regards, Bernard.