From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id F1797FB84 for ; Tue, 20 Dec 2016 14:40:05 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 20 Dec 2016 05:40:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,378,1477983600"; d="scan'208,217";a="1102005961" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 20 Dec 2016 05:40:02 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Dec 2016 13:40:01 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by irsmsx112.ger.corp.intel.com ([169.254.1.86]) with mapi id 14.03.0248.002; Tue, 20 Dec 2016 13:40:01 +0000 From: "Iremonger, Bernard" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Zhang, Helin" , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Chen, Jing D" Thread-Topic: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from PF Thread-Index: AQHSV9AjUoJYv6Y5OE+RKNJR4I2a8qEQ2S+AgAAC3XA= Date: Tue, 20 Dec 2016 13:40:00 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D17A76@IRSMSX108.ger.corp.intel.com> References: <20161216143919.4909-1-ferruh.yigit@intel.com> <20161216190257.6921-1-ferruh.yigit@intel.com> <20161216190257.6921-30-ferruh.yigit@intel.com> <587a2f08-0541-3f99-d16f-1c14206f11e9@intel.com> In-Reply-To: <587a2f08-0541-3f99-d16f-1c14206f11e9@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTlhNmMyZWYtODViNS00NWIwLThjNmItYzdiYzk4NzUxMzkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJEVGlMRFwvcUtGZDBUVVVDWmtWNVRPRXNoZ01JXC9sVmZhclRBUzhZTXdaaE09In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 13:40:06 -0000 Hi Ferruh, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, December 20, 2016 1:25 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Zhang, Helin > ; Zhang, Qi Z ; Lu, Wenzhuo > ; Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats fro= m > PF >=20 > On 12/16/2016 7:02 PM, Ferruh Yigit wrote: > > From: Qi Zhang > > > > This patch add support to get/clear VF statistics from PF side. > > Two APIs are added: > > rte_pmd_i40e_get_vf_stats. > > rte_pmd_i40e_reset_vf_stats. > > > > Signed-off-by: Qi Zhang > > --- >=20 > <...> >=20 > > diff --git a/drivers/net/i40e/rte_pmd_i40e_version.map > > b/drivers/net/i40e/rte_pmd_i40e_version.map > > index 8ac1bc8..7a5d211 100644 > > --- a/drivers/net/i40e/rte_pmd_i40e_version.map > > +++ b/drivers/net/i40e/rte_pmd_i40e_version.map > > @@ -6,7 +6,9 @@ DPDK_2.0 { > > DPDK_17.02 { > > global: > > > > + rte_pmd_i40e_get_vf_stats; > > rte_pmd_i40e_ping_vfs; > > + rte_pmd_i40e_reset_vf_stats; > > rte_pmd_i40e_set_tx_loopback; > > rte_pmd_i40e_set_vf_broadcast; > > rte_pmd_i40e_set_vf_mac_addr; >=20 > Hi Wenzhuo, Mark, >=20 > I think this is the list of all APIs added with this patchset. >=20 > Just a question, what do you think following a logic in API naming as: > __ ? >=20 > So API names become: > rte_pmd_i40e_tx_loopback_set; > rte_pmd_i40e_vf_broadcast_set; > rte_pmd_i40e_vf_mac_addr_set; > rte_pmd_i40e_vfs_ping; > rte_pmd_i40e_vf_stats_get; > rte_pmd_i40e_vf_stats_reset; >=20 >=20 > After above rename, rte_pmd_i40e_tx_loopback_set() is not giving a hint > that this is something related to the PF controlling VF, perhaps we can > rename the API ? >=20 > Also rte_pmd_i40e_vfs_ping() can become rte_pmd_i40e_vf_ping_all() to > be more consistent about _vf_ usage. >=20 > Overall, they can be something like: > rte_pmd_i40e_vf_broadcast_set; > rte_pmd_i40e_vf_mac_addr_set; > rte_pmd_i40e_vf_ping_all; > rte_pmd_i40e_vf_stats_get; > rte_pmd_i40e_vf_stats_reset; > rte_pmd_i40e_vf_tx_loopback_set; >=20 > What do you think? >=20 I think the naming should be consistent with what has already been implemen= ted for the ixgbe PMD. rte_pmd_ixgbe_set_all_queues_drop_en; rte_pmd_ixgbe_set_tx_loopback; rte_pmd_ixgbe_set_vf_mac_addr; rte_pmd_ixgbe_set_vf_mac_anti_spoof; rte_pmd_ixgbe_set_vf_split_drop_en; rte_pmd_ixgbe_set_vf_vlan_anti_spoof; rte_pmd_ixgbe_set_vf_vlan_insert; rte_pmd_ixgbe_set_vf_vlan_stripq; rte_pmd_ixgbe_set_vf_rate_limit; rte_pmd_ixgbe_set_vf_rx; rte_pmd_ixgbe_set_vf_rxmode; rte_pmd_ixgbe_set_vf_tx; rte_pmd_ixgbe_set_vf_vlan_filter; Regards, Bernard.