From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id 65F4310DA7
for <dev@dpdk.org>; Thu, 22 Dec 2016 17:38:49 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by orsmga104.jf.intel.com with ESMTP; 22 Dec 2016 08:38:48 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,389,1477983600"; d="scan'208";a="46093275"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
by fmsmga006.fm.intel.com with ESMTP; 22 Dec 2016 08:38:47 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by
IRSMSX106.ger.corp.intel.com ([169.254.8.66]) with mapi id 14.03.0248.002;
Thu, 22 Dec 2016 16:38:46 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Yigit, Ferruh"
<ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Wu, Jingjing" <jingjing.wu@intel.com>, "Zhang, Helin"
<helin.zhang@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Chen, Jing D"
<jing.d.chen@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from PF
Thread-Index: AQHSV9AjUoJYv6Y5OE+RKNJR4I2a8qEQ2S+AgAAC3XCAAL5TAIAClwtA
Date: Thu, 22 Dec 2016 16:38:45 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C224D1894F@IRSMSX108.ger.corp.intel.com>
References: <20161216143919.4909-1-ferruh.yigit@intel.com>
<20161216190257.6921-1-ferruh.yigit@intel.com>
<20161216190257.6921-30-ferruh.yigit@intel.com>
<587a2f08-0541-3f99-d16f-1c14206f11e9@intel.com>
<8CEF83825BEC744B83065625E567D7C224D17A76@IRSMSX108.ger.corp.intel.com>
<6A0DE07E22DDAD4C9103DF62FEBC09093B54C602@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B54C602@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQ2ZGY1MjgtZTJiNS00NDI2LWFlY2UtMTk0NDFhZjU4YzdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJDdEltUmVUSHF5R012Tndwb2p4QXlYWG5yaTluNm9IcnN5REZIcFh5ZldFPSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from PF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Dec 2016 16:38:50 -0000
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Wednesday, December 21, 2016 12:56 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats fro=
m PF
>=20
> Hi all,
>=20
>=20
> > -----Original Message-----
> > From: Iremonger, Bernard
> > Sent: Tuesday, December 20, 2016 9:40 PM
> > To: Yigit, Ferruh; dev@dpdk.org
> > Cc: Wu, Jingjing; Zhang, Helin; Zhang, Qi Z; Lu, Wenzhuo; Chen, Jing D
> > Subject: RE: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats
> > from PF
> >
> > Hi Ferruh,
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> > > Sent: Tuesday, December 20, 2016 1:25 PM
> > > To: dev@dpdk.org
> > > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> > > <helin.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Lu,
> > > Wenzhuo <wenzhuo.lu@intel.com>; Chen, Jing D
> <jing.d.chen@intel.com>
> > > Subject: Re: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF
> > > stats from PF
> > >
> > > On 12/16/2016 7:02 PM, Ferruh Yigit wrote:
> > > > From: Qi Zhang <qi.z.zhang@intel.com>
> > > >
> > > > This patch add support to get/clear VF statistics from PF side.
> > > > Two APIs are added:
> > > > rte_pmd_i40e_get_vf_stats.
> > > > rte_pmd_i40e_reset_vf_stats.
> > > >
> > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > > > ---
> > >
> > > <...>
> > >
> > > > diff --git a/drivers/net/i40e/rte_pmd_i40e_version.map
> > > > b/drivers/net/i40e/rte_pmd_i40e_version.map
> > > > index 8ac1bc8..7a5d211 100644
> > > > --- a/drivers/net/i40e/rte_pmd_i40e_version.map
> > > > +++ b/drivers/net/i40e/rte_pmd_i40e_version.map
> > > > @@ -6,7 +6,9 @@ DPDK_2.0 {
> > > > DPDK_17.02 {
> > > > global:
> > > >
> > > > + rte_pmd_i40e_get_vf_stats;
> > > > rte_pmd_i40e_ping_vfs;
> > > > + rte_pmd_i40e_reset_vf_stats;
> > > > rte_pmd_i40e_set_tx_loopback;
> > > > rte_pmd_i40e_set_vf_broadcast;
> > > > rte_pmd_i40e_set_vf_mac_addr;
> > >
> > > Hi Wenzhuo, Mark,
> > >
> > > I think this is the list of all APIs added with this patchset.
> > >
> > > Just a question, what do you think following a logic in API naming as=
:
> > > <name_space>_<object>_<action> ?
> > >
> > > So API names become:
> > > rte_pmd_i40e_tx_loopback_set;
> > > rte_pmd_i40e_vf_broadcast_set;
> > > rte_pmd_i40e_vf_mac_addr_set;
> > > rte_pmd_i40e_vfs_ping;
> > > rte_pmd_i40e_vf_stats_get;
> > > rte_pmd_i40e_vf_stats_reset;
> > >
> > >
> > > After above rename, rte_pmd_i40e_tx_loopback_set() is not giving a
> > > hint that this is something related to the PF controlling VF,
> > > perhaps we can rename the API ?
> > >
> > > Also rte_pmd_i40e_vfs_ping() can become rte_pmd_i40e_vf_ping_all()
> > > to be more consistent about _vf_ usage.
> > >
> > > Overall, they can be something like:
> > > rte_pmd_i40e_vf_broadcast_set;
> > > rte_pmd_i40e_vf_mac_addr_set;
> > > rte_pmd_i40e_vf_ping_all;
> > > rte_pmd_i40e_vf_stats_get;
> > > rte_pmd_i40e_vf_stats_reset;
> > > rte_pmd_i40e_vf_tx_loopback_set;
> > >
> > > What do you think?
> > >
> >
> > I think the naming should be consistent with what has already been
> > implemented for the ixgbe PMD.
> > rte_pmd_ixgbe_set_all_queues_drop_en;
> > rte_pmd_ixgbe_set_tx_loopback;
> > rte_pmd_ixgbe_set_vf_mac_addr;
> > rte_pmd_ixgbe_set_vf_mac_anti_spoof;
> > rte_pmd_ixgbe_set_vf_split_drop_en;
> > rte_pmd_ixgbe_set_vf_vlan_anti_spoof;
> > rte_pmd_ixgbe_set_vf_vlan_insert;
> > rte_pmd_ixgbe_set_vf_vlan_stripq;
> >
> > rte_pmd_ixgbe_set_vf_rate_limit;
> > rte_pmd_ixgbe_set_vf_rx;
> > rte_pmd_ixgbe_set_vf_rxmode;
> > rte_pmd_ixgbe_set_vf_tx;
> > rte_pmd_ixgbe_set_vf_vlan_filter;
> So, seems better to use the current names. Rework both ixgbe and i40e's
> later. Not sure if it'll be counted as the ABI change if we change the ix=
gbe's
> name.
>=20
A similar naming convention was used originally in the ethdev:
rte_eth_dev_set_vf_rxmode
rte_eth_dev_set_vf_rx
rte_eth_dev_set_vf_tx
rte_eth_dev_set_vf_vlan_filter
rte_eth_dev_set_vf_rate_limit
rte_eth_dev has just been replaced with rte_pmd_<ixgbe|i40e>
Regards,
Bernard.