From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 4546F37AF;
 Mon,  9 Jan 2017 10:50:10 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 09 Jan 2017 01:50:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="1091651763"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by fmsmga001.fm.intel.com with ESMTP; 09 Jan 2017 01:50:09 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.44]) with mapi id 14.03.0248.002;
 Mon, 9 Jan 2017 09:50:05 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault
 in	close
Thread-Index: AQHSZ7xKP1B1V8GtA0S37ua1ZcezVqErVdbAgASUiQCAAAFIYA==
Date: Mon, 9 Jan 2017 09:50:04 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C224D1BCBA@IRSMSX108.ger.corp.intel.com>
References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>
 <1483426488-117332-1-git-send-email-wenzhuo.lu@intel.com>
 <1483426488-117332-27-git-send-email-wenzhuo.lu@intel.com>
 <9BB6961774997848B5B42BEC655768F810CC3E79@SHSMSX103.ccr.corp.intel.com>
 <8CEF83825BEC744B83065625E567D7C224D1B4CF@IRSMSX108.ger.corp.intel.com>
 <9BB6961774997848B5B42BEC655768F810CC5369@SHSMSX103.ccr.corp.intel.com>
In-Reply-To: <9BB6961774997848B5B42BEC655768F810CC5369@SHSMSX103.ccr.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDk5NDA5YzItZGRlYi00NGZhLTkyMjMtNzkxM2RiZWRmZGM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ4b1VvZ09YTll4alBWSlpLUUFhR1BYMHJVYUNxaDVyOHNJbFRXVDFFc1hZPSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault
	in	close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2017 09:50:12 -0000

Hi Jingjing,

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, January 9, 2017 9:44 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault=
 in
> close
>=20
> >
> > All of the VSI's are released in the call to
> > i40e_vsi_release(pf->main_vsi) at line 1895.
> > This function is recursive and release all the VSI's.
> >
> > There is still a VSI address in pf->vmdq[i].vsi  but calling
> > i40e_vsi_release(pf-
> > >vmdq[i].vsi);
> > Results in a segmentation fault.
> >
> Thanks for the clarification.
>=20
> You are correct. What I prefer is to move the code to release vmdq vsis t=
o
> before the  i40e_vsi_release(pf->main_vsi);
>=20
> What do you think?
>=20
> Thanks
> Jingjing

I will test it and see what happens.

Regards,

Bernard.