From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 94A472C08 for ; Fri, 3 Feb 2017 10:21:27 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 03 Feb 2017 01:21:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,328,1477983600"; d="scan'208";a="816594497" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by FMSMGA003.fm.intel.com with ESMTP; 03 Feb 2017 01:21:25 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by irsmsx110.ger.corp.intel.com ([169.254.15.101]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 09:21:24 +0000 From: "Iremonger, Bernard" To: "Ananyev, Konstantin" , "Yigit, Ferruh" , "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get Thread-Index: AQHSdrRVmJLdJkk1L0OaPxQ7iIDXnKFUYgmAgAAVB4CAAAhVAIACkG+A Date: Fri, 3 Feb 2017 09:21:24 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D25A9D@IRSMSX108.ger.corp.intel.com> References: <1485311962-62335-1-git-send-email-wenzhuo.lu@intel.com> <2601191342CEEE43887BDE71AB9772583F10FFA1@irsmsx105.ger.corp.intel.com> <410cf75d-0ceb-d372-778f-bfa19392443b@intel.com> <2601191342CEEE43887BDE71AB9772583F110053@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772583F110053@irsmsx105.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzJlMDNkNDgtMmI4NC00OGVjLWE5ZWMtYTY0ZDAyMGY1MjQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJLRVREamQrWm02RWpvSkx3MU5GTmZ6T29weHBVVHhUTnZQTURhSUhTdWxZPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 09:21:28 -0000 Hi Konstantin, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Wednesday, February 1, 2017 6:10 PM > To: Yigit, Ferruh ; Lu, Wenzhuo > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get >=20 >=20 >=20 > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Wednesday, February 1, 2017 5:40 PM > > To: Ananyev, Konstantin ; Lu, Wenzhuo > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up > > rte_eth_dev_info_get > > > > On 2/1/2017 4:24 PM, Ananyev, Konstantin wrote: > > > Hi Wenzhuo, > > > > > >> -----Original Message----- > > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > >> Sent: Wednesday, January 25, 2017 2:39 AM > > >> To: dev@dpdk.org > > >> Cc: Lu, Wenzhuo > > >> Subject: [dpdk-dev] [PATCH] net/ixgbe: clean up > > >> rte_eth_dev_info_get > > >> > > >> It'not appropriate to call rte_eth_dev_info_get in PMD, as > > >> rte_eth_dev_info_get need to get info from PMD. > > >> Remove rte_eth_dev_info_get from PMD code and get the info > > >> directly. > > >> > > >> Signed-off-by: Wenzhuo Lu > > >> --- > > >> drivers/net/ixgbe/ixgbe_ethdev.c | 144 > > >> ++++++++++++++++++--------------------- > > >> 1 file changed, 68 insertions(+), 76 deletions(-) > > >> > > >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > >> b/drivers/net/ixgbe/ixgbe_ethdev.c > > >> index 64ce55a..f14a68b 100644 > > >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > >> @@ -4401,17 +4401,17 @@ static int > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > > >> int rar_entry; > > >> uint8_t *new_mac =3D (uint8_t *)(mac_addr); > > >> struct rte_eth_dev *dev; > > >> - struct rte_eth_dev_info dev_info; > > >> + struct rte_pci_device *pci_dev; > > >> > > >> RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > > >> > > >> dev =3D &rte_eth_devices[port]; > > >> - rte_eth_dev_info_get(port, &dev_info); > > >> + pci_dev =3D IXGBE_DEV_TO_PCI(dev); > > >> > > >> - if (is_ixgbe_pmd(dev_info.driver_name) !=3D 0) > > >> + if (is_ixgbe_pmd(dev->data->drv_name)) > > >> return -ENOTSUP; > > > > > > I wonder why do we need now that it is really an ixgbe device all ove= r the > place? > > > > This device specific API, so it is missing merits of abstraction > > layer, application can these APIs with any port_id, API should be prote= cted > for it. >=20 > Ah ok, my bad - didn't realize from the patch that it affects only device > specific API :) Would It be too much hassle to move these functions into = a > separate file (rte_ixgbe_pmd.c or so)? > Konstantin >=20 > > > > > Konstantin > > > All the device specific API functions are prefixed with rte_pmd_ixgbe so I = don't think a separate file is necessary. Regards, Bernard.