From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 909CF2E8A for ; Wed, 12 Apr 2017 14:30:28 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2017 05:30:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,190,1488873600"; d="scan'208";a="73002103" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga002.jf.intel.com with ESMTP; 12 Apr 2017 05:30:27 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX103.ger.corp.intel.com ([169.254.3.241]) with mapi id 14.03.0319.002; Wed, 12 Apr 2017 13:30:26 +0100 From: "Iremonger, Bernard" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Xing, Beilei" , "Lu, Wenzhuo" , "Zhang, Qi" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used Thread-Index: AQHSstSvEnECnubwfkyXS0LFdKRUPqHBjZKAgAAc/HA= Date: Wed, 12 Apr 2017 12:30:25 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D52F48@IRSMSX108.ger.corp.intel.com> References: <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E706115308B12A@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115308B12A@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTVhYThjZmUtMWQwMi00YWExLWE2N2UtYTdhOTI0ZWIzMjFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkU3ZytIT1wvenhxcDdwZGJ2QVNcL3lHK0o5MXl1T1VwQnNaQWJBdzZTK3FOQT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 12:30:30 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, April 12, 2017 12:43 PM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Zhang, Qi ; Iremonger, > Bernard > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is no= t > used >=20 > Hi Bernard: >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard > Iremonger > > Sent: Tuesday, April 11, 2017 11:01 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Lu, Wenzhuo > > ; Zhang, Qi ; Iremonger, > > Bernard > > Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not > > used > > > > In rx vector mode, the QinQ VLAN tag is not stripped. > > When hw_vlan_extend is set for QinQ ensure that rx vector mode is not > > selected. > > > > Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from > > vector > > driver") >=20 > Why fixes? I didn't see above commit change rx callback function if > hw_vlan_extend =3D=3D 1 Some of the QinQ functionality was introduced in 17.02, this functionality = also has the same issue. So I added a fixes line. > > > > Signed-off-by: Bernard Iremonger > > --- > > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > > b/drivers/net/i40e/i40e_rxtx_vec_common.h > > index 952fd4b63..692096684 100644 > > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > > @@ -234,6 +234,10 @@ > > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev > *dev) > > if (rxmode->header_split =3D=3D 1) > > return -1; > > > > + /* no QinQ support */ > > + if (rxmode->hw_vlan_extend =3D=3D 1) > > + return -1; > > + > > return 0; > > #else > > RTE_SET_USED(dev); > > -- > > 2.11.0 Regards, Bernard.