From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9DF4C2E8A for ; Wed, 12 Apr 2017 15:54:15 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2017 06:54:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,190,1488873600"; d="scan'208";a="247719482" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga004.fm.intel.com with ESMTP; 12 Apr 2017 06:54:13 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 12 Apr 2017 14:54:13 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by irsmsx155.ger.corp.intel.com ([169.254.14.202]) with mapi id 14.03.0319.002; Wed, 12 Apr 2017 14:54:12 +0100 From: "Iremonger, Bernard" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Xing, Beilei" , "Lu, Wenzhuo" , "Zhang, Qi" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used Thread-Index: AQHSstSvEnECnubwfkyXS0LFdKRUPqHBjZKAgAAc/HD///N3gIAAISUA Date: Wed, 12 Apr 2017 13:54:12 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D53012@IRSMSX108.ger.corp.intel.com> References: <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E706115308B12A@SHSMSX103.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D52F48@IRSMSX108.ger.corp.intel.com> <039ED4275CED7440929022BC67E706115308B186@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115308B186@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzdkMTQ1ZDAtYjIxYi00ZTRiLTlhYWUtYWQ1MWQ0MzA3NjU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNi41LjkuMyIsIlRydXN0ZWRMYWJlbEhhc2giOiJaVCt4QTdvNGVVK0hyYXRzUkUyTlE3dVwvdXUweEo4cHNsRHIwU0NCZzVBST0ifQ== x-ctpclassification: CTP_PUBLIC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 13:54:17 -0000 Hi Qi, > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Wednesday, April 12, 2017 12:43 PM > > > To: Iremonger, Bernard ; dev@dpdk.org > > > Cc: Xing, Beilei ; Lu, Wenzhuo > > > ; Zhang, Qi ; Iremonger, > > > Bernard > > > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode > > > is not used > > > > > > Hi Bernard: > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard > > > Iremonger > > > > Sent: Tuesday, April 11, 2017 11:01 PM > > > > To: dev@dpdk.org > > > > Cc: Xing, Beilei ; Lu, Wenzhuo > > > > ; Zhang, Qi ; > Iremonger, > > > > Bernard > > > > Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is > > > > not used > > > > > > > > In rx vector mode, the QinQ VLAN tag is not stripped. > > > > When hw_vlan_extend is set for QinQ ensure that rx vector mode is > > > > not selected. > > > > > > > > Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from > > > > vector > > > > driver") > > > > > > Why fixes? I didn't see above commit change rx callback function if > > > hw_vlan_extend =3D=3D 1 > > > > Some of the QinQ functionality was introduced in 17.02, this > > functionality also has the same issue. > > So I added a fixes line. >=20 > If you think this patch is a fix, you need to find the commit that introd= uce this > issue The commit ca74903b75cf is not the root cause of the issue, it just= move > the code from I40e_rxtx_vec.c to i40e_rxtx_vec_common.h >=20 > Regards > Qi >=20 This is a fix to the i40e_rx_vec_dev_conf_condition_check_default() functi= on. The issue is caused because there is no check on the hw_vlan_extend flag = at present. This is the correct fixline for that function. ca74903b75 (Jianbo Liu 2016-10-14 09:30:00 +0530 221) i40e_rx_vec_dev_con= f_condition_check_default(struct rte_eth_dev *dev) I will send a v2 as I should have added the "Cc: stable@dpdk.org" line. Regards, Bernard.