From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 888F147CE for ; Thu, 11 May 2017 19:31:05 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 May 2017 10:31:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,325,1491289200"; d="scan'208";a="100934316" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga006.fm.intel.com with ESMTP; 11 May 2017 10:31:03 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 11 May 2017 18:31:02 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by irsmsx112.ger.corp.intel.com ([169.254.1.61]) with mapi id 14.03.0319.002; Thu, 11 May 2017 18:31:02 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon , "Mcnamara, John" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide Thread-Index: AQHSynqhC2rTqD63O0u3ulTKStGmmqHvY3Zw Date: Thu, 11 May 2017 17:31:01 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D5D178@IRSMSX108.ger.corp.intel.com> References: <1494511780-5732-1-git-send-email-john.mcnamara@intel.com> <6951954.sJVyEfo4GT@xps> <3737023.yBcUv04Hz8@xps> In-Reply-To: <3737023.yBcUv04Hz8@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTk5YTRhNzQtMDhiOC00MDNlLWJjNDQtZjBlYTY3ZTM3NWY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNlYmdrK3Rjd3VzYk5xVXJYTnhENmtTU3pFalFSQUxON0ZoNE9DUWtZZHc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 17:31:06 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, May 11, 2017 6:18 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in > contributors guide >=20 > 11/05/2017 18:11, Mcnamara, John: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > ... > > > > -* The recommended style for the DPDK documentation is to put > > > > sentences > > > on separate lines. > > > > - This allows for easier reviewing of patches. > > > > - Multiple sentences which are not separated by a blank line are > > > > joined > > > automatically into paragraphs, for example:: > > > > +* Lines in sentences should be less than 80 characters and > > > > +wrapped at > > > > + words. Multiple sentences which are not separated by a blank > > > > +line are joined > > > > + automatically into paragraphs. > > > > > > Why not keep the recommendation of separating sentences? > > > > This isn't a recommendation. It is just pointing out that lines and > > sentences are joined into paragraphs. Maybe that is obvious and > > doesn't need to be stated. >=20 > I'm talking about "The recommended style for the DPDK documentation is to > put sentences on separate lines." > I like this recommendation. +1 for this recommendation >=20 > > > > + testpmd -l 2-3 -n 4 \ > > > > + --vdev=3Dvirtio_user0,path=3D/dev/vhost- > > > net,queues=3D2,queue_size=3D1024 \ > > > > + -- -i --txqflags=3D0x0 --disable-hw-vlan --enable-lro= \ > > > > + --enable-rx-cksum --txq=3D2 --rxq=3D2 --rxd=3D1024 > > > > + --txd=3D1024 > > > > > > Garbage? > > > > I hope not. I took it from one of the examples in the docs to > > demonstrate how a long command could be wrapped and still be > > functional. Should I clarify that more, or remove it? >=20 > Ah sorry, misreading the patch. Regards, Bernard.