From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id F06B51B20C; Fri, 29 Sep 2017 10:27:42 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2017 01:27:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,451,1500966000"; d="scan'208";a="1200352384" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 29 Sep 2017 01:27:41 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Fri, 29 Sep 2017 09:27:40 +0100 From: "Iremonger, Bernard" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "adrien.mazarguil@6wind.com" CC: "stable@dpdk.org" Thread-Topic: [PATCH v5 2/6] librte_table: fix acl lookup function Thread-Index: AQHTJ/h43YmxPT79EEuLChSlRD6CV6K9thAAgA3zLvA= Date: Fri, 29 Sep 2017 08:27:39 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E04BA56@IRSMSX108.ger.corp.intel.com> References: <1504693668-2062-1-git-send-email-bernard.iremonger@intel.com> <1504802598-27296-3-git-send-email-bernard.iremonger@intel.com> <3EB4FA525960D640B5BDFFD6A3D891267BABCEB2@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891267BABCEB2@IRSMSX108.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDg2OTk5MjctODJkMy00YjMxLWJiZDctMjFjNDU5NDc0MTRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkVuVVk1eVVmemVPK0U2VFkyd2FPUXN6Q1FsTGIzdmk1Y1lZXC93eU8rRVlVPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/6] librte_table: fix acl lookup function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 08:27:43 -0000 Hi Cristian, > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Wednesday, September 20, 2017 1:24 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Yigit, Ferruh ; Ananyev, Konstantin > ; adrien.mazarguil@6wind.com > Cc: stable@dpdk.org > Subject: RE: [PATCH v5 2/6] librte_table: fix acl lookup function >=20 >=20 >=20 > > -----Original Message----- > > From: Iremonger, Bernard > > Sent: Thursday, September 7, 2017 5:43 PM > > To: dev@dpdk.org; Yigit, Ferruh ; Ananyev, > > Konstantin ; Dumitrescu, Cristian > > ; adrien.mazarguil@6wind.com > > Cc: Iremonger, Bernard ; > stable@dpdk.org > > Subject: [PATCH v5 2/6] librte_table: fix acl lookup function > > > > The rte_table_acl_lookup() function was returning data from acl_memory > > instead of acl_rule_memory. > > > > Fixes: 166923eb2f78 ("table: ACL") > > Cc: stable@dpdk.org > > > > Signed-off-by: Bernard Iremonger > > --- > > lib/librte_table/rte_table_acl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_table/rte_table_acl.c > > b/lib/librte_table/rte_table_acl.c > > index e84b437..258916d 100644 > > --- a/lib/librte_table/rte_table_acl.c > > +++ b/lib/librte_table/rte_table_acl.c > > @@ -794,7 +794,7 @@ struct rte_table_acl { > > if (action_table_pos !=3D 0) { > > pkts_out_mask |=3D pkt_mask; > > entries[pkt_pos] =3D (void *) > > - &acl->memory[action_table_pos * > > + &acl->acl_rule_memory[action_table_pos * > > acl->entry_size]; > > rte_prefetch0(entries[pkt_pos]); > > } > > -- > > 1.9.1 >=20 > NACK >=20 > Existing code is correct, proposed code changes are wrong (for same reaso= ns > described in patch 1 of this patch set). I will drop this patch and send a v6 patch set. Regards, Bernard.