From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CE4F83790 for ; Tue, 24 Oct 2017 11:53:57 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2017 02:53:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; d="scan'208";a="141604092" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga004.jf.intel.com with ESMTP; 24 Oct 2017 02:53:55 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX102.ger.corp.intel.com ([169.254.2.180]) with mapi id 14.03.0319.002; Tue, 24 Oct 2017 10:53:54 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon , "Mcnamara, John" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "Dumitrescu, Cristian" , "adrien.mazarguil@6wind.com" , "Singh, Jasvinder" , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v10 0/4] flow classification library Thread-Index: AQHTTBHrKeMjxtKc3EGONSRli7utL6Lx2p6AgADQ9cD///8agIAABDiAgAARgbA= Date: Tue, 24 Oct 2017 09:53:53 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E055671@IRSMSX108.ger.corp.intel.com> References: <1508679124-5922-1-git-send-email-bernard.iremonger@intel.com> <8CEF83825BEC744B83065625E567D7C24E055559@IRSMSX108.ger.corp.intel.com> <2419109.dR6RbCMRoY@xps> In-Reply-To: <2419109.dR6RbCMRoY@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGY2NDc3ZmMtODMyNy00Y2ExLTlmZWQtNjdiNTQ1ODczY2Q1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imx3UnpZZmc4bW5xK2h6czlVekF0ZE40aTdtMVh0bUltTjh0dmRFT0lHWWM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v10 0/4] flow classification library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 09:53:58 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, October 24, 2017 10:39 AM > To: Mcnamara, John ; Iremonger, Bernard > > Cc: dev@dpdk.org; Yigit, Ferruh ; Ananyev, > Konstantin ; Dumitrescu, Cristian > ; adrien.mazarguil@6wind.com; Singh, > Jasvinder > Subject: Re: [dpdk-dev] [PATCH v10 0/4] flow classification library >=20 > 24/10/2017 11:23, Mcnamara, John: > > From: Iremonger, Bernard > > > > > > Hi Thomas, > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > I suppose you are OK to wait one more release and call for more > > > reviewers? > > > > > > This library was not ready for 17.11.RC1 having received some > > > comments just before the RC1 deadline. > > > It was then targeted for RC2 and we have pulled out all the stops to > > > get it ready for RC2. > > > > > > It is now at v10 of the patch set, there have been no review > > > comments from the community (apart from Intel), since RFC v3. > > > > > > I think that there has been ample time for the community to review > > > this patch set, calling for more reviewers at this point is not helpf= ul. >=20 > I have to review some basic things in your series. > I did not take time to review it because I thought John told me it would = not > make 17.11. >=20 > > > The API's of the library are marked as experimental, so there will > > > be no issues with ABI breakage, if there are requests for changes lat= er. >=20 > It is not marked EXPERIMENTAL in the MAINTAINERS file. My mistake, it is marked as experimental in rte_flow_classify_version.map I can send a v11 patch set if needed. =20 > > > I am not OK to wait one more release, I believe we have followed the > > > process correctly. >=20 > Yes, you followed the process. >=20 > > +1 for inclusion in RC2. >=20 > It is not common to add a new library in RC2. >=20 > When doing the RC1 announce, I did not mention this library as a possible > inclusion exception in RC2, and I had no feedback: > http://dpdk.org/ml/archives/announce/2017-October/000153.html I probably should have replied to this email. =20 > I was really sure you were not targetting 17.11. We have always been targeting 17.11 > So I did not do the last pass review. Probably my mistake. >=20 > We are having a hard time with 17.11 release, so I would prefer avoiding > adding one more new library at this stage. This is a new library and should not impact anyone. I believe we have followed the process, so I think it should not be deferre= d to 18.02. Regards, Bernard.