From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bernard.iremonger@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 124E51B5EA for <dev@dpdk.org>; Thu, 2 Nov 2017 18:29:27 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2017 10:29:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,335,1505804400"; d="scan'208";a="1032737125" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 02 Nov 2017 10:29:25 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Thu, 2 Nov 2017 17:29:25 +0000 From: "Iremonger, Bernard" <bernard.iremonger@intel.com> To: "Mcnamara, John" <john.mcnamara@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Iremonger, Bernard" <bernard.iremonger@intel.com> Thread-Topic: [PATCH 1/2] doc: flow classify library prog guide Thread-Index: AQHTTjotF8sLv8m3M0+QqulVmMYlTKMBWyOAgAAHa7A= Date: Thu, 2 Nov 2017 17:29:24 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E05A913@IRSMSX108.ger.corp.intel.com> References: <1509008957-11812-1-git-send-email-bernard.iremonger@intel.com> <1509008957-11812-2-git-send-email-bernard.iremonger@intel.com> <B27915DBBA3421428155699D51E4CFE23EDEFE0C@IRSMSX103.ger.corp.intel.com> In-Reply-To: <B27915DBBA3421428155699D51E4CFE23EDEFE0C@IRSMSX103.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDRlMmE5MmYtNzY3ZS00ZjczLTkwNzYtYmRjZDk2MWQyYmFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkpNMG5RMGd4NWVXQ2NCcm0xU3RYSEozWEZBQTVJRXEzT3N2K01DWmZTOFk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] doc: flow classify library prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 02 Nov 2017 17:29:28 -0000 Hi John, <snip> > > Subject: [PATCH 1/2] doc: flow classify library prog guide > > > > This file documents the Flow Classification library, librte_flow_classi= fy. > > > > Updated MAINTAINERS file > > > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> >=20 > Hi Bernard, >=20 > Thanks for the doc. >=20 > There is a doc build warning due to a reference to a file that is in the = 2/2 > patch: >=20 > $ make doc-guides-html -j > sphinx processing guides-html... > /work/dpdk_docs/doc/guides/prog_guide/flow_classify_lib.rst:64: > WARNING: unknown document: ../sample_app_ug/flow_classify >=20 Both docs reference each other. I could squash the patches into one, or add a third patch with the referenc= e. Which option would you prefer?=20 >=20 > There are also 2 x s/classifer/classifier/ typos in this patch and 1 in 2= /2. I will fix typo's >=20 > John >=20 >=20 Thanks for the review. Regards, Bernard.