From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BDA2CBD34 for ; Tue, 17 Apr 2018 16:24:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 07:24:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="217260890" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga005.jf.intel.com with ESMTP; 17 Apr 2018 07:24:54 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX101.ger.corp.intel.com ([169.254.1.176]) with mapi id 14.03.0319.002; Tue, 17 Apr 2018 15:24:53 +0100 From: "Iremonger, Bernard" To: Xueming Li , "Lu, Wenzhuo" , "Wu, Jingjing" , Thomas Monjalon , Yongseok Koh , Olivier MATZ , Shahaf Shuler CC: "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 2/4] app/testpmd: testpmd support Tx generic tunnel offloads Thread-Index: AQHTzzXUlzlGSFjol0W+HqNcwHL+ZaQFEOMA Date: Tue, 17 Apr 2018 14:24:52 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E0AEA4D@IRSMSX108.ger.corp.intel.com> References: <20180109141110.146250-2-xuemingl@mellanox.com> <20180408123240.110698-3-xuemingl@mellanox.com> In-Reply-To: <20180408123240.110698-3-xuemingl@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODhlMTZlNzQtYzBmMC00OTZlLWE1ZTQtZDFiODhmYzhmODAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJLMWhSa25qRG0xcG9iMnFOSE9ybnRFdGo5ZnlCUnJ0ZENHcFwvRW91MURWZGFUSE14eFRnVDkwUURBVlwvKzJFM3gifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/4] app/testpmd: testpmd support Tx generic tunnel offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 14:24:57 -0000 Hi Lu, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xueming Li > Sent: Sunday, April 8, 2018 1:33 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Thomas Monjalon ; > Yongseok Koh ; Olivier MATZ > ; Shahaf Shuler > Cc: Xueming Li ; Yigit, Ferruh > ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 2/4] app/testpmd: testpmd support Tx generi= c > tunnel offloads >=20 > "show port cap" and "csum parse tunnel" command support TX generic tunnel > offloads >=20 > Signed-off-by: Xueming Li > --- > app/test-pmd/cmdline.c | 14 ++++++++++++-- > app/test-pmd/config.c | 17 +++++++++++++++++ > app/test-pmd/csumonly.c | 3 ++- > 3 files changed, 31 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 40b31ad7e..a81112220 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -4013,6 +4013,12 @@ check_tunnel_tso_nic_support(portid_t port_id) > if (!(dev_info.tx_offload_capa & > DEV_TX_OFFLOAD_GENEVE_TNL_TSO)) > printf("Warning: GENEVE TUNNEL TSO not supported therefore > " > "not enabled for port %d\n", port_id); > + if (!(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IP_TNL_TSO)) > + printf("Warning: IP TUNNEL TSO not supported therefore " > + "not enabled for port %d\n", port_id); > + if (!(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_TNL_TSO)) > + printf("Warning: UDP TUNNEL TSO not supported therefore " > + "not enabled for port %d\n", port_id); > return dev_info; > } >=20 > @@ -4040,13 +4046,17 @@ cmd_tunnel_tso_set_parsed(void *parsed_result, > ~(DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > DEV_TX_OFFLOAD_GRE_TNL_TSO | > DEV_TX_OFFLOAD_IPIP_TNL_TSO | > - DEV_TX_OFFLOAD_GENEVE_TNL_TSO); > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO | > + DEV_TX_OFFLOAD_IP_TNL_TSO | > + DEV_TX_OFFLOAD_UDP_TNL_TSO); > printf("TSO for tunneled packets is disabled\n"); > } else { > uint64_t tso_offloads =3D (DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > DEV_TX_OFFLOAD_GRE_TNL_TSO | > DEV_TX_OFFLOAD_IPIP_TNL_TSO | > - > DEV_TX_OFFLOAD_GENEVE_TNL_TSO); > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO > | > + DEV_TX_OFFLOAD_IP_TNL_TSO | > + DEV_TX_OFFLOAD_UDP_TNL_TSO); >=20 > ports[res->port_id].dev_conf.txmode.offloads |=3D > (tso_offloads & dev_info.tx_offload_capa); diff --git > a/app/test-pmd/config.c b/app/test-pmd/config.c index 4bb255c62..481d2b62= d > 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -722,6 +722,23 @@ port_offload_cap_display(portid_t port_id) > printf("off\n"); > } >=20 > + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IP_TNL_TSO) { > + printf("IP tunnel TSO: "); > + if (ports[port_id].dev_conf.txmode.offloads & > + DEV_TX_OFFLOAD_IP_TNL_TSO) > + printf("on\n"); > + else > + printf("off\n"); > + } > + > + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_TNL_TSO) { > + printf("UDP tunnel TSO: "); > + if (ports[port_id].dev_conf.txmode.offloads & > + DEV_TX_OFFLOAD_UDP_TNL_TSO) > + printf("on\n"); > + else > + printf("off\n"); > + } > } >=20 > int > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index > 5f5ab64aa..7b2309372 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -693,7 +693,8 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > info.l3_len); > parse_vxlan(udp_hdr, &info, m->packet_type); > if (info.is_tunnel) > - tx_ol_flags |=3D > PKT_TX_TUNNEL_VXLAN; > + tx_ol_flags |=3D > (PKT_TX_TUNNEL_VXLAN | > + PKT_TX_OUTER_UDP); > } else if (info.l4_proto =3D=3D IPPROTO_GRE) { > struct simple_gre_hdr *gre_hdr; >=20 > -- > 2.13.3 This patch fails to compile on latest master branch. /root/dpdk_sforge_2/app/test-pmd/csumonly.c: In function 'pkt_burst_checksu= m_forward': /root/dpdk_sforge_2/app/test-pmd/csumonly.c:700:8: error: 'PKT_TX_OUTER_UDP= ' undeclared (first use in this function) PKT_TX_OUTER_UDP); ^ /root/dpdk_sforge_2/app/test-pmd/csumonly.c:700:8: note: each undeclared id= entifier is reported only once for each function it appears in make[5]: *** [csumonly.o] Error 1 make[4]: *** [test-pmd] Error 2 make[3]: *** [app] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 Regards, Bernard.