From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 498BC1C7E0; Fri, 11 May 2018 18:09:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 May 2018 09:09:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,389,1520924400"; d="scan'208";a="57844745" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga002.jf.intel.com with ESMTP; 11 May 2018 09:09:45 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX107.ger.corp.intel.com ([169.254.10.141]) with mapi id 14.03.0319.002; Fri, 11 May 2018 17:09:44 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon , "Lu, Wenzhuo" , "Doherty, Declan" CC: "stable@dpdk.org" , Matan Azrad , "dev@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix slave port detection Thread-Index: AQHT2o1ulZLOAialRUip+s7BytG1o6Qqz1sg Date: Fri, 11 May 2018 16:09:43 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CA4F4@IRSMSX108.ger.corp.intel.com> References: <1522235873-22042-1-git-send-email-matan@mellanox.com> <2044227.RGsR745gvM@xps> In-Reply-To: <2044227.RGsR745gvM@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzVhMjIxMjQtYWJjMy00YTQyLWJkNWEtMTIyMzFmMmIyZTk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMjROQ3ZxWVVIWXMxanZYVVROc20xK3E1Wk5MNGJ0RGFyTmVjT25VTVBnRDFWN1ZQWk5NZmVDSGVoMUlva2FqVyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix slave port detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 16:09:47 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, April 22, 2018 11:58 PM > To: Lu, Wenzhuo ; Doherty, Declan > > Cc: stable@dpdk.org; Matan Azrad ; dev@dpdk.org; > Yigit, Ferruh > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix slave port > detection >=20 > Wenzhuo, Declan, > Any comment or ack, please? >=20 > 28/03/2018 13:17, Matan Azrad: > > Testpmd allows to create and control bonding devices by run time > > command lines using the bonding PMD API. > > > > Some bonding device slaves operations(close, stop, etc) should not be > > used by the application and must be managed by the bonding PMD. > > > > Thus, Testpmd manages slave flags to prevent the special operations > > calls and when a slave is added to bonding device by a run time > > command line, the flag is set. > > > > There is one more way to define the slaves for a bonding device using > > EAL command line and Testpmd doesn't set the slave flag in this case > > what causes to the special operations to be called by Testpmd. > > > > Add one more check to detect bonding slave device. > > > > Fixes: 41b05095c4d1 ("app/testpmd: fix bonding start") > > Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in > > bonding") > > Cc: stable@dpdk.org > > > > Signed-off-by: Matan Azrad Acked-by: Bernard Iremonger