From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 698F11E874
for <dev@dpdk.org>; Thu, 14 Jun 2018 12:18:03 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
14 Jun 2018 03:18:02 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,222,1526367600"; d="scan'208";a="232531612"
Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96])
by orsmga005.jf.intel.com with ESMTP; 14 Jun 2018 03:17:47 -0700
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Thu, 14 Jun 2018 11:17:46 +0100
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by
IRSMSX156.ger.corp.intel.com ([169.254.3.252]) with mapi id 14.03.0319.002;
Thu, 14 Jun 2018 11:17:46 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "dev@dpdk.org"
<dev@dpdk.org>
CC: Stephen Hemminger <sthemmin@microsoft.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/2] testpmd: use RFC values for Tx
address and port
Thread-Index: AQHUAbGqmcqG/gqSb0u5HzM1LBztraRfjMSQ
Date: Thu, 14 Jun 2018 10:17:46 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C260CB347E@IRSMSX108.ger.corp.intel.com>
References: <20180611182526.32327-1-stephen@networkplumber.org>
<20180611182526.32327-2-stephen@networkplumber.org>
In-Reply-To: <20180611182526.32327-2-stephen@networkplumber.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzJhNTcyNTEtZjUxNy00YjAyLWExNzAtOGZhY2Y5YWNjNWEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib09NaWVZM1dZTURVZUsyUllnUzhkbzFDaVJTdzFZVDlveGRZRjFNcUF2bjFQMk5vOUhkb3hkWjIwUmc1N2F0cyJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 1/2] testpmd: use RFC values for Tx
address and port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 10:18:04 -0000
Hi Stephen,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Monday, June 11, 2018 7:25 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Stephen
> Hemminger <sthemmin@microsoft.com>
> Subject: [dpdk-dev] [PATCH v2 1/2] testpmd: use RFC values for Tx address
> and port
>=20
> Change the IP address and UDP port used for testpmd Tx only test. The old
> values overlap common NAT local networks; instead use reserved addresses
> in IETF RFC 2544.
The commit message should probably refer to RFC 863 too.
>=20
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
> app/test-pmd/txonly.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>=20
> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index
> 1f08b6ed37a2..a24000e3af44 100644
> --- a/app/test-pmd/txonly.c
> +++ b/app/test-pmd/txonly.c
> @@ -40,11 +40,13 @@
>=20
> #include "testpmd.h"
>=20
> -#define UDP_SRC_PORT 1024
> -#define UDP_DST_PORT 1024
> +/* RFC863 discard port */
> +#define UDP_SRC_PORT 9
> +#define UDP_DST_PORT 9
>=20
> -#define IP_SRC_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 1) -#define
> IP_DST_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 2)
> +/* RFC2544 reserved test subnet 192.18.0.0 */ #define IP_SRC_ADDR
> +((192U << 24) | (18 << 16) | (0 << 8) | 1) #define IP_DST_ADDR ((192U
> +<< 24) | (18 << 16) | (0 << 8) | 2)
>=20
> #define IP_DEFTTL 64 /* from RFC 1340. */
> #define IP_VERSION 0x40
> --
> 2.17.1
dpdk/devtools/check-git-log.sh is showing the following error
Wrong headline label:
testpmd: use RFC values for Tx address and port
It should be app/testpmd
Regards,
Bernard.