From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 492BA1D4D8 for ; Thu, 14 Jun 2018 14:59:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2018 05:59:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,222,1526367600"; d="scan'208";a="48966221" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga007.jf.intel.com with ESMTP; 14 Jun 2018 05:59:29 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX106.ger.corp.intel.com ([169.254.8.80]) with mapi id 14.03.0319.002; Thu, 14 Jun 2018 13:59:28 +0100 From: "Iremonger, Bernard" To: "Guo, Jia" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "gaetan.rivet@6wind.com" , "Wu, Jingjing" , "thomas@monjalon.net" , "motih@mellanox.com" , "matan@mellanox.com" , "Van Haaren, Harry" , "Tan, Jianfeng" CC: "jblunck@infradead.org" , "shreyansh.jain@nxp.com" , "dev@dpdk.org" , "Guo, Jia" , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle hot unplug Thread-Index: AQHT4syqZQ8jrzK5PEOJNoC1kbsFBqRf+KHA Date: Thu, 14 Jun 2018 12:59:27 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CB36FD@IRSMSX108.ger.corp.intel.com> References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1525344524-26946-1-git-send-email-jia.guo@intel.com> <1525344524-26946-5-git-send-email-jia.guo@intel.com> In-Reply-To: <1525344524-26946-5-git-send-email-jia.guo@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDRkZjYyZmYtZWFlNS00M2NkLTg4Y2YtYWJhNDljMGQzZjUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZk1hXC8xWjNVcXpMMVJ5c0prazhIU0E0eEpXdGpyUnZFXC9RT3hEdHgxQmI4ZFhJc3pvcUJlODFpR1pWMkxsUjVcLyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle hot unplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 12:59:32 -0000 Hi Jeff, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jeff Guo > Sent: Thursday, May 3, 2018 11:49 AM > To: stephen@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; > gaetan.rivet@6wind.com; Wu, Jingjing ; > thomas@monjalon.net; motih@mellanox.com; matan@mellanox.com; Van > Haaren, Harry ; Tan, Jianfeng > > Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Guo, > Jia ; Zhang, Helin > Subject: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle > hot unplug >=20 > Use testpmd for example, to show how an application smoothly handle > failure when device being hot unplug. Once app detect the removal event, > the callback would be called, it first stop the packet forwarding, then s= top the > port, close the port and finally detach the port. >=20 > Signed-off-by: Jeff Guo > --- > v21->v20: > fix attach port issue, let it work for multiple device case. > combind rmv callback to only one. > --- > app/test-pmd/testpmd.c | 27 ++++++++++++++++++--------- > 1 file changed, 18 insertions(+), 9 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > db23f23..a1ff8f3 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1908,9 +1908,10 @@ eth_dev_event_callback_unregister(void) > void > attach_port(char *identifier) > { > - portid_t pi =3D 0; > unsigned int socket_id; >=20 > + portid_t pi =3D rte_eth_dev_count_avail(); > + > printf("Attaching a new port...\n"); >=20 > if (identifier =3D=3D NULL) { > @@ -2071,12 +2072,14 @@ rmv_event_callback(void *arg) > RTE_ETH_VALID_PORTID_OR_RET(port_id); > dev =3D &rte_eth_devices[port_id]; >=20 > + if (dev->state =3D=3D RTE_ETH_DEV_UNUSED) > + return; > + > + printf("removing device %s\n", dev->device->name); > + stop_packet_forwarding(); > stop_port(port_id); > close_port(port_id); > - printf("removing device %s\n", dev->device->name); > - if (rte_eal_dev_detach(dev->device)) > - TESTPMD_LOG(ERR, "Failed to detach device %s\n", > - dev->device->name); > + detach_port(port_id); > } >=20 > /* This function is used by the interrupt thread */ @@ -2131,19 +2134,26 > @@ static void eth_dev_event_callback(char *device_name, enum > rte_dev_event_type type, > __rte_unused void *arg) > { > + uint16_t port_id; > + int ret; > + > if (type >=3D RTE_DEV_EVENT_MAX) { > fprintf(stderr, "%s called upon invalid event %d\n", > __func__, type); > fflush(stderr); > } >=20 > + ret =3D rte_eth_dev_get_port_by_name(device_name, &port_id); > + if (ret) { > + printf("can not get port by device %s!\n", device_name); > + return; > + } > + > switch (type) { > case RTE_DEV_EVENT_REMOVE: > RTE_LOG(ERR, EAL, "The device: %s has been removed!\n", > device_name); > - /* TODO: After finish failure handle, begin to stop > - * packet forward, stop port, close port, detach port. > - */ > + rmv_event_callback((void *)(intptr_t)port_id); > break; > case RTE_DEV_EVENT_ADD: > RTE_LOG(ERR, EAL, "The device: %s has been added!\n", > @@ -2666,7 +2676,6 @@ main(int argc, char** argv) > return -1; > } > eth_dev_event_callback_register(); > - > } >=20 > if (start_port(RTE_PORT_ALL) !=3D 0) > -- > 2.7.4 This patch fails to apply to dpdk 18.08-rc0 and needs to be rebased. Regards, Bernard.