From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 925301DD1D for ; Thu, 14 Jun 2018 16:44:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2018 07:44:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,222,1526367600"; d="scan'208";a="237159245" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga005.fm.intel.com with ESMTP; 14 Jun 2018 07:44:14 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX151.ger.corp.intel.com ([169.254.4.216]) with mapi id 14.03.0319.002; Thu, 14 Jun 2018 15:44:13 +0100 From: "Iremonger, Bernard" To: "Hu, Jiayu" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Hu, Jiayu" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine Thread-Index: AQHT9x+NrXFDyhTcN02TqloGg2Hz2aRf5cSQ Date: Thu, 14 Jun 2018 14:44:12 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CB37DB@IRSMSX108.ger.corp.intel.com> References: <1527579670-91026-1-git-send-email-jiayu.hu@intel.com> <1527579670-91026-3-git-send-email-jiayu.hu@intel.com> In-Reply-To: <1527579670-91026-3-git-send-email-jiayu.hu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzdjMTNhMWQtY2M4YS00MjdjLWFmNjctMDkyNGEzOGY4NjI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFwvWjhqNWFKSG1pVU5pSWt4XC9Ncm5YbElPR1d2WCtaNlBtWEorSkRZMHRWaGVNeGJcL0pTNFNqMUFHT2pjTUhWbCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 14:44:17 -0000 Hi Jiayu, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu > Sent: Tuesday, May 29, 2018 8:41 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Hu, Jiayu > > Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the > checksum forwarding engine >=20 > This patch enables GSO for UDP/IPv4 packets. Oversized UDP/IPv4 packets > transmitted over a GSO-enabled port will undergo segmentation. >=20 > Signed-off-by: Jiayu Hu > --- > app/test-pmd/cmdline.c | 5 +++-- > app/test-pmd/csumonly.c | 2 ++ > app/test-pmd/testpmd.c | 2 +- > 3 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 27e2aa8..4239e91 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -4792,8 +4792,9 @@ cmd_gso_show_parsed(void *parsed_result, > if (gso_ports[res->cmd_pid].enable) { > printf("Max GSO'd packet size: %uB\n" > "Supported GSO types: TCP/IPv4, " > - "VxLAN with inner TCP/IPv4 packet, " > - "GRE with inner TCP/IPv4 packet\n", > + "UDP/IPv4, VxLAN with inner " > + "TCP/IPv4 packet, GRE with inner " > + "TCP/IPv4 packet\n", This change is giving 3 checkpatch.pl warnings and should be refactored > gso_max_segment_size); > } else > printf("GSO is not enabled on Port %u\n", res- > >cmd_pid); diff --git a/app/test-pmd/csumonly.c b/app/test- > pmd/csumonly.c index 0bb88cf..4948292 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -411,6 +411,8 @@ process_inner_cksums(void *l3_hdr, const struct > testpmd_offload_info *info, > info->ethertype); > } > } > + if (info->gso_enable) > + ol_flags |=3D PKT_TX_UDP_SEG; > } else if (info->l4_proto =3D=3D IPPROTO_TCP) { > tcp_hdr =3D (struct tcp_hdr *)((char *)l3_hdr + info->l3_len); > tcp_hdr->cksum =3D 0; > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 35cf266..b5766ff 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -777,7 +777,7 @@ init_config(void) > init_port_config(); >=20 > gso_types =3D DEV_TX_OFFLOAD_TCP_TSO | > DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > - DEV_TX_OFFLOAD_GRE_TNL_TSO; > + DEV_TX_OFFLOAD_GRE_TNL_TSO | > DEV_TX_OFFLOAD_UDP_TSO; > /* > * Records which Mbuf pool to use by each logical core, if needed. > */ > -- > 2.7.4 ./devtools/check-git-log.sh -1 Headline too long: app/testpmd: enable UDP GSO in the checksum forwarding engine Should the dpdk/doc/guides/testpmd_ap_ug/testpmd_funcs.rst file be updated= ? Regards, Bernard