From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id E74BE4C7B
 for <dev@dpdk.org>; Thu, 28 Jun 2018 14:45:51 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 28 Jun 2018 05:45:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,283,1526367600"; d="scan'208";a="211870572"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by orsmga004.jf.intel.com with ESMTP; 28 Jun 2018 05:45:49 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by
 IRSMSX101.ger.corp.intel.com ([169.254.1.148]) with mapi id 14.03.0319.002;
 Thu, 28 Jun 2018 13:45:48 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Singh, Jasvinder"
 <jasvinder.singh@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "Pattan, Reshma"
 <reshma.pattan@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3 23/23] app/testpmd: rework softnic
 forward	mode
Thread-Index: AQHUDtFf3MgdiS5GFUWUQrPW5RpvSKR1nZbQ
Date: Thu, 28 Jun 2018 12:45:48 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C260CBA317@IRSMSX108.ger.corp.intel.com>
References: <20180615165224.25004-2-jasvinder.singh@intel.com>
 <20180627163123.135686-1-jasvinder.singh@intel.com>
 <20180627163123.135686-24-jasvinder.singh@intel.com>
 <8CEF83825BEC744B83065625E567D7C260CBA18F@IRSMSX108.ger.corp.intel.com>
 <54CBAA185211B4429112C315DA58FF6D335ABE52@IRSMSX103.ger.corp.intel.com>
 <8CEF83825BEC744B83065625E567D7C260CBA232@IRSMSX108.ger.corp.intel.com>
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CBA232@IRSMSX108.ger.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2UwMThiOWUtYTk2Mi00NGFhLWJiNDEtZGRkMTJkNmQ1NjVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYmNDSmlzNjZBZWhtNEtQNmtaVFgrWkFlUEc4MWxCWDUzZ0dhSTVuWE5ZeXpRWmZUZGFpZEx6cGN3MEF0OUhyRyJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 23/23] app/testpmd: rework softnic
	forward	mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2018 12:45:52 -0000

Hi Jasvinder,

<snip>

> > > > -----Original Message-----
> > > > From: Singh, Jasvinder
> > > > Sent: Wednesday, June 27, 2018 5:31 PM
> > > > To: dev@dpdk.org
> > > > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
> > > > Iremonger, Bernard <bernard.iremonger@intel.com>; Pattan, Reshma
> > > > <reshma.pattan@intel.com>
> > > > Subject: [PATCH v3 23/23] app/testpmd: rework softnic forward mode
> > > >
> > > > Modied the testpmd softnic forwarding mode as per the changes in
> > > > softnic PMD.
> > > >
> > > > To run testpmd application with softnic fwd mode, following
> > > > command is used;
> > > >
> > > > $ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firmware=3Dscript.cli'
> > > >   -- -i --forward-mode=3Dsoftnic
> > > >
> > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > > > ---
> > >
> > > <snip>
> > >
> > > This patch fails to compile on the latest 18.08 master branch.
> > >
> > > I don't see any updateto the testpmd *.rst files.
> > >
> >
> >
> > Bernard, Could you please provide me the build log?
>=20
> /root/dpdk_sforge_2/app/test-pmd/cmdline.c: In function 'prompt':
>   LD dpdk-pdump
> /root/dpdk_sforge_2/app/test-pmd/cmdline.c:17584:3: error: implicit
> declaration of function 'rte_pmd_softnic_manage' [-Werror=3Dimplicit-
> function-declaration]
>    rte_pmd_softnic_manage(softnic_portid);
>    ^
> /root/dpdk_sforge_2/app/test-pmd/cmdline.c:17584:3: error: nested extern
> declaration of 'rte_pmd_softnic_manage' [-Werror=3Dnested-externs]
>   LD dpdk-test-eventdev
>   LD testbbdev
> cc1: all warnings being treated as errors
> /root/dpdk_sforge_2/mk/internal/rte.compile-pre.mk:114: recipe for target
> 'cmdline.o' failed
> make[5]: *** [cmdline.o] Error 1
> /root/dpdk_sforge_2/mk/rte.subdir.mk:35: recipe for target 'test-pmd'
> failed
> make[4]: *** [test-pmd] Error 2
> make[4]: *** Waiting for unfinished jobs....
>   INSTALL-APP dpdk-procinfo
>   INSTALL-MAP dpdk-procinfo.map
>   INSTALL-APP dpdk-test-crypto-perf
>   INSTALL-MAP dpdk-test-crypto-perf.map
>   INSTALL-APP dpdk-pdump
>   INSTALL-MAP dpdk-pdump.map
>   INSTALL-APP dpdk-test-eventdev
>   INSTALL-MAP dpdk-test-eventdev.map
>   INSTALL-MAP testbbdev.map
>   INSTALL-APP testbbdev
> /root/dpdk_sforge_2/mk/rte.sdkbuild.mk:49: recipe for target 'app' failed
> make[3]: *** [app] Error 2
> /root/dpdk_sforge_2/mk/rte.sdkroot.mk:100: recipe for target 'all' failed
> make[2]: *** [all] Error 2
> /root/dpdk_sforge_2/mk/rte.sdkinstall.mk:57: recipe for target 'pre_insta=
ll'
> failed
> make[1]: *** [pre_install] Error 2
> /root/dpdk_sforge_2/mk/rte.sdkroot.mk:79: recipe for target 'install' fai=
led
> make: *** [install] Error 2
>=20
> Regards,
>=20
> Bernard.

It is compiling for me now (I missed a patch when applying the patches).
Sorry for any inconvenience caused.

Regards,

Bernard.