From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9E6D2F72 for ; Tue, 24 Jul 2018 14:41:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 05:41:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,398,1526367600"; d="scan'208";a="69809077" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 24 Jul 2018 05:41:37 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Jul 2018 13:41:36 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX156.ger.corp.intel.com ([169.254.3.205]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 13:41:36 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon , "Singh, Jasvinder" CC: "dev@dpdk.org" , "Pattan, Reshma" , "motih@mellanox.com" , "olivier.matz@6wind.com" , "Dumitrescu, Cristian" , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInI33Sz2THmWPE+WbTizGY8086SeLF2AgAATHYCAABJLAA== Date: Tue, 24 Jul 2018 12:41:36 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CCEE52@IRSMSX107.ger.corp.intel.com> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1876510.4y0gDTZx5Q@xps> <1925999.Zqez9Xlb98@xps> In-Reply-To: <1925999.Zqez9Xlb98@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTllNWM1YWUtMzZiZC00MzBhLTk0OWMtM2Q5M2E0Mzc3ZDRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibEd5VVlRSEpiMlEwZmxtTVhCOHZcLytrcHRSTEZPWmZ2VUpkWG0xV1BkY2t2dCtUNXNLUWM1MnlOXC9TSFBUVDFxIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 12:41:40 -0000 Hi Thomas, +John > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, July 24, 2018 1:34 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; motih@mellanox.com; > olivier.matz@6wind.com; Dumitrescu, Cristian > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 > Important note: > testpmd is currently really broken. > We cannot have a RC2 until it is fixed. >=20 >=20 > 24/07/2018 13:25, Thomas Monjalon: > > 23/07/2018 12:44, Jasvinder Singh: > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission > > > character (EOT) on the empty command line. > > > > Please describe what is the issue and what is the cause. > > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > > > Reported-by: Mordechay Haimovsky > > > Signed-off-by: Jasvinder Singh > > > --- > > > app/test-pmd/cmdline.c | 10 ++++++---- > > > lib/librte_cmdline/cmdline.c | 2 +- > > > > It is very suspicious to change the cmdline library. > > If there is a bug in this library, it deserves a separate fix. >=20 >=20 Do you know what commit has broken testpmd? Regards, Bernard