From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 23E584CA2; Tue, 11 Sep 2018 18:23:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2018 09:23:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,361,1531810800"; d="scan'208";a="69185153" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga007.fm.intel.com with ESMTP; 11 Sep 2018 09:23:11 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.116]) by IRSMSX154.ger.corp.intel.com ([169.254.12.187]) with mapi id 14.03.0319.002; Tue, 11 Sep 2018 17:23:11 +0100 From: "Iremonger, Bernard" To: dev , "dev@dpdk.org" CC: "nd@arm.com" , "gavin.hu@arm.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocation Thread-Index: AQHUPekShhmgzRtxzESqHGdlMfS3vqTrWvyg Date: Tue, 11 Sep 2018 16:23:10 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CEECCC@IRSMSX107.ger.corp.intel.com> References: <1535362398-6526-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1535362398-6526-1-git-send-email-phil.yang@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGU2ZThiNjgtOGNkOC00NDUyLTk5NjUtYTdmYmVhOTBjM2ZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidER6Snp6XC9BREhSXC84VjZ6RjNrUlRFRFhJa3Jta01HUlU4TUFRRXVGSDk0cXVTUVRcL1llSG5acUpiT00xNVwvdjkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 16:23:14 -0000 Hi Gavin, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] > Sent: Monday, August 27, 2018 10:33 AM > To: dev@dpdk.org > Cc: nd@arm.com; gavin.hu@arm.com > Subject: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocation >=20 > By default, testpmd will create membuf pool for all NUMA nodes and ignore= EAL > configuration. >=20 > Count the number of available NUMA according to EAL core mask or core lis= t > configuration. Optimized by only creating membuf pool for those nodes. >=20 > Fixes: d5aeab6542f ("app/testpmd: fix mempool creation by socket id") >=20 > Signed-off-by: Phil Yang > --- > app/test-pmd/testpmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > ee48db2..a56af2b 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -476,6 +476,8 @@ set_default_fwd_lcores_config(void) >=20 > nb_lc =3D 0; > for (i =3D 0; i < RTE_MAX_LCORE; i++) { > + if (!rte_lcore_is_enabled(i)) > + continue; > sock_num =3D rte_lcore_to_socket_id(i); > if (new_socket_id(sock_num)) { > if (num_sockets >=3D RTE_MAX_NUMA_NODES) { @@ - > 485,8 +487,6 @@ set_default_fwd_lcores_config(void) > } > socket_ids[num_sockets++] =3D sock_num; > } > - if (!rte_lcore_is_enabled(i)) > - continue; > if (i =3D=3D rte_get_master_lcore()) > continue; > fwd_lcores_cpuids[nb_lc++] =3D i; > -- > 2.7.4 ./dpdk/devtools/check-git-log.sh -1 Wrong headline uppercase: app/testpmd: Optimize membuf pool allocation Wrong 'Fixes' reference: Fixes: d5aeab6542f ("app/testpmd: fix mempool creation by socket id= ") Regards, Bernard.