From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id ECCBD58FE for ; Tue, 25 Sep 2018 12:33:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 03:33:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,301,1534834800"; d="scan'208";a="89141049" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2018 03:33:00 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.116]) by IRSMSX108.ger.corp.intel.com ([169.254.11.13]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 11:33:00 +0100 From: "Iremonger, Bernard" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Wu, Jingjing" Thread-Topic: [PATCH] app/testpmd: fix metering and policing cli command Thread-Index: AQHUSndlmToA6Y1DakKmLcSppq9zjaUA4CxQ Date: Tue, 25 Sep 2018 10:32:59 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CF336C@IRSMSX107.ger.corp.intel.com> References: <20180912090202.124518-1-jasvinder.singh@intel.com> In-Reply-To: <20180912090202.124518-1-jasvinder.singh@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDQ1Mzg2Y2QtNTVjMC00NzdlLTgxYTYtYWZlNTYxNTRhMjVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMkdNYVJ0cGpXZGE1NXY1TTZWRWxybjhORm9SV2J5QXQ5Q0pscnVXZWhyVUNoYm1ZZUxOeE5WQlUxZ283U3BibCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 10:33:10 -0000 Hi Jasvinder, > -----Original Message----- > From: Singh, Jasvinder > Sent: Wednesday, September 12, 2018 10:02 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Subject: [PATCH] app/testpmd: fix metering and policing cli command >=20 > Fixes bad arguments error for cli commands related to adding meter profil= e > for srtcm_rfc2697, trtcm_rfc2698 and trtcm_rfc4115. >=20 > error log: > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 > testpmd> 2500000 2500000 > Bad arguments >=20 > Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and > policing") >=20 > Signed-off-by: Jasvinder Singh > --- > app/test-pmd/cmdline_mtr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c > index f908fb3..32a4730 100644 > --- a/app/test-pmd/cmdline_mtr.c > +++ b/app/test-pmd/cmdline_mtr.c > @@ -414,9 +414,9 @@ cmdline_parse_inst_t > cmd_add_port_meter_profile_srtcm =3D { > (void *)&cmd_add_port_meter_profile_srtcm_port, > (void *)&cmd_add_port_meter_profile_srtcm_meter, > (void *)&cmd_add_port_meter_profile_srtcm_profile, > + (void > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > (void *)&cmd_add_port_meter_profile_srtcm_port_id, > (void *)&cmd_add_port_meter_profile_srtcm_profile_id, > - (void > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > (void *)&cmd_add_port_meter_profile_srtcm_cir, > (void *)&cmd_add_port_meter_profile_srtcm_cbs, > (void *)&cmd_add_port_meter_profile_srtcm_ebs, > @@ -521,9 +521,9 @@ cmdline_parse_inst_t > cmd_add_port_meter_profile_trtcm =3D { > (void *)&cmd_add_port_meter_profile_trtcm_port, > (void *)&cmd_add_port_meter_profile_trtcm_meter, > (void *)&cmd_add_port_meter_profile_trtcm_profile, > + (void > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > (void *)&cmd_add_port_meter_profile_trtcm_port_id, > (void *)&cmd_add_port_meter_profile_trtcm_profile_id, > - (void > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > (void *)&cmd_add_port_meter_profile_trtcm_cir, > (void *)&cmd_add_port_meter_profile_trtcm_pir, > (void *)&cmd_add_port_meter_profile_trtcm_cbs, > @@ -633,9 +633,9 @@ cmdline_parse_inst_t > cmd_add_port_meter_profile_trtcm_rfc4115 =3D { > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port, > (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter, > (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile, > + (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id, > (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id, > - (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir, > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir, > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs, > -- > 2.9.3 ./devtools/check-git-log.sh -1 Line too long: testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 312500= 0000 2500000 2500000 Also when I execute the command I get the following error: testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 250= 0000 2500000 cause unspecified: Function not implemented (error 1) Is some more configuration needed to use this command? Regards, Bernard.