* [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command
@ 2018-09-12 9:02 Jasvinder Singh
2018-09-25 10:32 ` Iremonger, Bernard
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Jasvinder Singh @ 2018-09-12 9:02 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, jingjing.wu, bernard.iremonger
Fixes bad arguments error for cli commands related to adding
meter profile for srtcm_rfc2697, trtcm_rfc2698 and trtcm_rfc4115.
error log:
testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 2500000 2500000
Bad arguments
Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
app/test-pmd/cmdline_mtr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index f908fb3..32a4730 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -414,9 +414,9 @@ cmdline_parse_inst_t cmd_add_port_meter_profile_srtcm = {
(void *)&cmd_add_port_meter_profile_srtcm_port,
(void *)&cmd_add_port_meter_profile_srtcm_meter,
(void *)&cmd_add_port_meter_profile_srtcm_profile,
+ (void *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697,
(void *)&cmd_add_port_meter_profile_srtcm_port_id,
(void *)&cmd_add_port_meter_profile_srtcm_profile_id,
- (void *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697,
(void *)&cmd_add_port_meter_profile_srtcm_cir,
(void *)&cmd_add_port_meter_profile_srtcm_cbs,
(void *)&cmd_add_port_meter_profile_srtcm_ebs,
@@ -521,9 +521,9 @@ cmdline_parse_inst_t cmd_add_port_meter_profile_trtcm = {
(void *)&cmd_add_port_meter_profile_trtcm_port,
(void *)&cmd_add_port_meter_profile_trtcm_meter,
(void *)&cmd_add_port_meter_profile_trtcm_profile,
+ (void *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698,
(void *)&cmd_add_port_meter_profile_trtcm_port_id,
(void *)&cmd_add_port_meter_profile_trtcm_profile_id,
- (void *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698,
(void *)&cmd_add_port_meter_profile_trtcm_cir,
(void *)&cmd_add_port_meter_profile_trtcm_pir,
(void *)&cmd_add_port_meter_profile_trtcm_cbs,
@@ -633,9 +633,9 @@ cmdline_parse_inst_t cmd_add_port_meter_profile_trtcm_rfc4115 = {
(void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port,
(void *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter,
(void *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile,
+ (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115,
(void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id,
(void *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id,
- (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115,
(void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir,
(void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir,
(void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs,
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command 2018-09-12 9:02 [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command Jasvinder Singh @ 2018-09-25 10:32 ` Iremonger, Bernard 2018-09-25 11:01 ` Singh, Jasvinder 2018-10-01 10:46 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh 2018-10-08 16:08 ` [dpdk-dev] [PATCH] " Dumitrescu, Cristian 2 siblings, 1 reply; 7+ messages in thread From: Iremonger, Bernard @ 2018-09-25 10:32 UTC (permalink / raw) To: Singh, Jasvinder, dev; +Cc: Lu, Wenzhuo, Wu, Jingjing Hi Jasvinder, > -----Original Message----- > From: Singh, Jasvinder > Sent: Wednesday, September 12, 2018 10:02 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com>; Iremonger, Bernard > <bernard.iremonger@intel.com> > Subject: [PATCH] app/testpmd: fix metering and policing cli command > > Fixes bad arguments error for cli commands related to adding meter profile > for srtcm_rfc2697, trtcm_rfc2698 and trtcm_rfc4115. > > error log: > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 > testpmd> 2500000 2500000 > Bad arguments > > Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and > policing") > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com> > --- > app/test-pmd/cmdline_mtr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c > index f908fb3..32a4730 100644 > --- a/app/test-pmd/cmdline_mtr.c > +++ b/app/test-pmd/cmdline_mtr.c > @@ -414,9 +414,9 @@ cmdline_parse_inst_t > cmd_add_port_meter_profile_srtcm = { > (void *)&cmd_add_port_meter_profile_srtcm_port, > (void *)&cmd_add_port_meter_profile_srtcm_meter, > (void *)&cmd_add_port_meter_profile_srtcm_profile, > + (void > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > (void *)&cmd_add_port_meter_profile_srtcm_port_id, > (void *)&cmd_add_port_meter_profile_srtcm_profile_id, > - (void > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > (void *)&cmd_add_port_meter_profile_srtcm_cir, > (void *)&cmd_add_port_meter_profile_srtcm_cbs, > (void *)&cmd_add_port_meter_profile_srtcm_ebs, > @@ -521,9 +521,9 @@ cmdline_parse_inst_t > cmd_add_port_meter_profile_trtcm = { > (void *)&cmd_add_port_meter_profile_trtcm_port, > (void *)&cmd_add_port_meter_profile_trtcm_meter, > (void *)&cmd_add_port_meter_profile_trtcm_profile, > + (void > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > (void *)&cmd_add_port_meter_profile_trtcm_port_id, > (void *)&cmd_add_port_meter_profile_trtcm_profile_id, > - (void > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > (void *)&cmd_add_port_meter_profile_trtcm_cir, > (void *)&cmd_add_port_meter_profile_trtcm_pir, > (void *)&cmd_add_port_meter_profile_trtcm_cbs, > @@ -633,9 +633,9 @@ cmdline_parse_inst_t > cmd_add_port_meter_profile_trtcm_rfc4115 = { > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port, > (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter, > (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile, > + (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id, > (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id, > - (void > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir, > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir, > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs, > -- > 2.9.3 ./devtools/check-git-log.sh -1 Line too long: testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 2500000 2500000 Also when I execute the command I get the following error: testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 2500000 2500000 cause unspecified: Function not implemented (error 1) Is some more configuration needed to use this command? Regards, Bernard. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command 2018-09-25 10:32 ` Iremonger, Bernard @ 2018-09-25 11:01 ` Singh, Jasvinder 2018-09-25 14:16 ` Iremonger, Bernard 0 siblings, 1 reply; 7+ messages in thread From: Singh, Jasvinder @ 2018-09-25 11:01 UTC (permalink / raw) To: Iremonger, Bernard, dev; +Cc: Lu, Wenzhuo, Wu, Jingjing > diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c > > index f908fb3..32a4730 100644 > > --- a/app/test-pmd/cmdline_mtr.c > > +++ b/app/test-pmd/cmdline_mtr.c > > @@ -414,9 +414,9 @@ cmdline_parse_inst_t > > cmd_add_port_meter_profile_srtcm = { > > (void *)&cmd_add_port_meter_profile_srtcm_port, > > (void *)&cmd_add_port_meter_profile_srtcm_meter, > > (void *)&cmd_add_port_meter_profile_srtcm_profile, > > + (void > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > > (void *)&cmd_add_port_meter_profile_srtcm_port_id, > > (void *)&cmd_add_port_meter_profile_srtcm_profile_id, > > - (void > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > > (void *)&cmd_add_port_meter_profile_srtcm_cir, > > (void *)&cmd_add_port_meter_profile_srtcm_cbs, > > (void *)&cmd_add_port_meter_profile_srtcm_ebs, > > @@ -521,9 +521,9 @@ cmdline_parse_inst_t > > cmd_add_port_meter_profile_trtcm = { > > (void *)&cmd_add_port_meter_profile_trtcm_port, > > (void *)&cmd_add_port_meter_profile_trtcm_meter, > > (void *)&cmd_add_port_meter_profile_trtcm_profile, > > + (void > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > > (void *)&cmd_add_port_meter_profile_trtcm_port_id, > > (void *)&cmd_add_port_meter_profile_trtcm_profile_id, > > - (void > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > > (void *)&cmd_add_port_meter_profile_trtcm_cir, > > (void *)&cmd_add_port_meter_profile_trtcm_pir, > > (void *)&cmd_add_port_meter_profile_trtcm_cbs, > > @@ -633,9 +633,9 @@ cmdline_parse_inst_t > > cmd_add_port_meter_profile_trtcm_rfc4115 = { > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port, > > (void > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter, > > (void > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile, > > + (void > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > > (void > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id, > > (void > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id, > > - (void > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir, > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir, > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs, > > -- > > 2.9.3 > > ./devtools/check-git-log.sh -1 > Line too long: > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 > 3125000000 2500000 2500000 > > > Also when I execute the command I get the following error: > > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 > testpmd> 2500000 2500000 > cause unspecified: Function not implemented (error 1) > > Is some more configuration needed to use this command? > Meter and policing support is only available in Softnic PMD, please trying using that when testing the CLI. Thanks, Jasvinder ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command 2018-09-25 11:01 ` Singh, Jasvinder @ 2018-09-25 14:16 ` Iremonger, Bernard 2018-09-25 14:20 ` Singh, Jasvinder 0 siblings, 1 reply; 7+ messages in thread From: Iremonger, Bernard @ 2018-09-25 14:16 UTC (permalink / raw) To: Singh, Jasvinder, dev; +Cc: Lu, Wenzhuo, Wu, Jingjing Hi Jasvinder, > -----Original Message----- > From: Singh, Jasvinder > Sent: Tuesday, September 25, 2018 12:02 PM > To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com> > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command > > > diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c > > > index f908fb3..32a4730 100644 > > > --- a/app/test-pmd/cmdline_mtr.c > > > +++ b/app/test-pmd/cmdline_mtr.c > > > @@ -414,9 +414,9 @@ cmdline_parse_inst_t > > > cmd_add_port_meter_profile_srtcm = { > > > (void *)&cmd_add_port_meter_profile_srtcm_port, > > > (void *)&cmd_add_port_meter_profile_srtcm_meter, > > > (void *)&cmd_add_port_meter_profile_srtcm_profile, > > > + (void > > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > > > (void *)&cmd_add_port_meter_profile_srtcm_port_id, > > > (void *)&cmd_add_port_meter_profile_srtcm_profile_id, > > > - (void > > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > > > (void *)&cmd_add_port_meter_profile_srtcm_cir, > > > (void *)&cmd_add_port_meter_profile_srtcm_cbs, > > > (void *)&cmd_add_port_meter_profile_srtcm_ebs, > > > @@ -521,9 +521,9 @@ cmdline_parse_inst_t > > > cmd_add_port_meter_profile_trtcm = { > > > (void *)&cmd_add_port_meter_profile_trtcm_port, > > > (void *)&cmd_add_port_meter_profile_trtcm_meter, > > > (void *)&cmd_add_port_meter_profile_trtcm_profile, > > > + (void > > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > > > (void *)&cmd_add_port_meter_profile_trtcm_port_id, > > > (void *)&cmd_add_port_meter_profile_trtcm_profile_id, > > > - (void > > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > > > (void *)&cmd_add_port_meter_profile_trtcm_cir, > > > (void *)&cmd_add_port_meter_profile_trtcm_pir, > > > (void *)&cmd_add_port_meter_profile_trtcm_cbs, > > > @@ -633,9 +633,9 @@ cmdline_parse_inst_t > > > cmd_add_port_meter_profile_trtcm_rfc4115 = { > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port, > > > (void > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter, > > > (void > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile, > > > + (void > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > > > (void > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id, > > > (void > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id, > > > - (void > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir, > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir, > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs, > > > -- > > > 2.9.3 > > > > ./devtools/check-git-log.sh -1 > > Line too long: > > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 > > 3125000000 2500000 2500000 > > > > > > Also when I execute the command I get the following error: > > > > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 > > testpmd> 3125000000 > > testpmd> 2500000 2500000 > > cause unspecified: Function not implemented (error 1) > > > > Is some more configuration needed to use this command? > > > Meter and policing support is only available in Softnic PMD, please trying > using that when testing the CLI. > > Thanks, > Jasvinder The fix works with the Softnic PMD. The commit message needs revision otherwise Acked-by: Bernard Iremonger <bernard.iremonger@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command 2018-09-25 14:16 ` Iremonger, Bernard @ 2018-09-25 14:20 ` Singh, Jasvinder 0 siblings, 0 replies; 7+ messages in thread From: Singh, Jasvinder @ 2018-09-25 14:20 UTC (permalink / raw) To: Iremonger, Bernard, dev; +Cc: Lu, Wenzhuo, Wu, Jingjing > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, September 25, 2018 3:16 PM > To: Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com> > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command > > Hi Jasvinder, > > > -----Original Message----- > > From: Singh, Jasvinder > > Sent: Tuesday, September 25, 2018 12:02 PM > > To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > > <jingjing.wu@intel.com> > > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli > > command > > > > > diff --git a/app/test-pmd/cmdline_mtr.c > > b/app/test-pmd/cmdline_mtr.c > > > > index f908fb3..32a4730 100644 > > > > --- a/app/test-pmd/cmdline_mtr.c > > > > +++ b/app/test-pmd/cmdline_mtr.c > > > > @@ -414,9 +414,9 @@ cmdline_parse_inst_t > > > > cmd_add_port_meter_profile_srtcm = { > > > > (void *)&cmd_add_port_meter_profile_srtcm_port, > > > > (void *)&cmd_add_port_meter_profile_srtcm_meter, > > > > (void *)&cmd_add_port_meter_profile_srtcm_profile, > > > > + (void > > > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > > > > (void *)&cmd_add_port_meter_profile_srtcm_port_id, > > > > (void *)&cmd_add_port_meter_profile_srtcm_profile_id, > > > > - (void > > > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > > > > (void *)&cmd_add_port_meter_profile_srtcm_cir, > > > > (void *)&cmd_add_port_meter_profile_srtcm_cbs, > > > > (void *)&cmd_add_port_meter_profile_srtcm_ebs, > > > > @@ -521,9 +521,9 @@ cmdline_parse_inst_t > > > > cmd_add_port_meter_profile_trtcm = { > > > > (void *)&cmd_add_port_meter_profile_trtcm_port, > > > > (void *)&cmd_add_port_meter_profile_trtcm_meter, > > > > (void *)&cmd_add_port_meter_profile_trtcm_profile, > > > > + (void > > > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > > > > (void *)&cmd_add_port_meter_profile_trtcm_port_id, > > > > (void *)&cmd_add_port_meter_profile_trtcm_profile_id, > > > > - (void > > > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > > > > (void *)&cmd_add_port_meter_profile_trtcm_cir, > > > > (void *)&cmd_add_port_meter_profile_trtcm_pir, > > > > (void *)&cmd_add_port_meter_profile_trtcm_cbs, > > > > @@ -633,9 +633,9 @@ cmdline_parse_inst_t > > > > cmd_add_port_meter_profile_trtcm_rfc4115 = { > > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port, > > > > (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter, > > > > (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile, > > > > + (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > > > > (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id, > > > > (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id, > > > > - (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir, > > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir, > > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs, > > > > -- > > > > 2.9.3 > > > > > > ./devtools/check-git-log.sh -1 > > > Line too long: > > > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 > > > 3125000000 2500000 2500000 > > > > > > > > > Also when I execute the command I get the following error: > > > > > > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 > > > testpmd> 3125000000 > > > testpmd> 2500000 2500000 > > > cause unspecified: Function not implemented (error 1) > > > > > > Is some more configuration needed to use this command? > > > > > Meter and policing support is only available in Softnic PMD, please > > trying using that when testing the CLI. > > > > Thanks, > > Jasvinder > > The fix works with the Softnic PMD. > > The commit message needs revision otherwise > > Acked-by: Bernard Iremonger <bernard.iremonger@intel.com> > Thanks, Bernard. Will send v2. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] app/testpmd: fix metering and policing cli command 2018-09-12 9:02 [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command Jasvinder Singh 2018-09-25 10:32 ` Iremonger, Bernard @ 2018-10-01 10:46 ` Jasvinder Singh 2018-10-08 16:08 ` [dpdk-dev] [PATCH] " Dumitrescu, Cristian 2 siblings, 0 replies; 7+ messages in thread From: Jasvinder Singh @ 2018-10-01 10:46 UTC (permalink / raw) To: dev; +Cc: bernard.iremonger Fixes bad arguments error for cli commands related to adding meter profile for srtcm_rfc2697, trtcm_rfc2698 and trtcm_rfc4115. error log: testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 2500000 2500000 Bad arguments Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com> --- v2 changes: - Fix checkpatch warning app/test-pmd/cmdline_mtr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index f908fb352..32a47305f 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -414,9 +414,9 @@ cmdline_parse_inst_t cmd_add_port_meter_profile_srtcm = { (void *)&cmd_add_port_meter_profile_srtcm_port, (void *)&cmd_add_port_meter_profile_srtcm_meter, (void *)&cmd_add_port_meter_profile_srtcm_profile, + (void *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, (void *)&cmd_add_port_meter_profile_srtcm_port_id, (void *)&cmd_add_port_meter_profile_srtcm_profile_id, - (void *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, (void *)&cmd_add_port_meter_profile_srtcm_cir, (void *)&cmd_add_port_meter_profile_srtcm_cbs, (void *)&cmd_add_port_meter_profile_srtcm_ebs, @@ -521,9 +521,9 @@ cmdline_parse_inst_t cmd_add_port_meter_profile_trtcm = { (void *)&cmd_add_port_meter_profile_trtcm_port, (void *)&cmd_add_port_meter_profile_trtcm_meter, (void *)&cmd_add_port_meter_profile_trtcm_profile, + (void *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, (void *)&cmd_add_port_meter_profile_trtcm_port_id, (void *)&cmd_add_port_meter_profile_trtcm_profile_id, - (void *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, (void *)&cmd_add_port_meter_profile_trtcm_cir, (void *)&cmd_add_port_meter_profile_trtcm_pir, (void *)&cmd_add_port_meter_profile_trtcm_cbs, @@ -633,9 +633,9 @@ cmdline_parse_inst_t cmd_add_port_meter_profile_trtcm_rfc4115 = { (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port, (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter, (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile, + (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id, (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id, - (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir, (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir, (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs, -- 2.17.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command 2018-09-12 9:02 [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command Jasvinder Singh 2018-09-25 10:32 ` Iremonger, Bernard 2018-10-01 10:46 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh @ 2018-10-08 16:08 ` Dumitrescu, Cristian 2 siblings, 0 replies; 7+ messages in thread From: Dumitrescu, Cristian @ 2018-10-08 16:08 UTC (permalink / raw) To: Singh, Jasvinder, dev; +Cc: Lu, Wenzhuo, Wu, Jingjing, Iremonger, Bernard > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Wednesday, September 12, 2018 10:02 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com>; Iremonger, Bernard > <bernard.iremonger@intel.com> > Subject: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli > command > > Fixes bad arguments error for cli commands related to adding > meter profile for srtcm_rfc2697, trtcm_rfc2698 and trtcm_rfc4115. > > error log: > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 3125000000 > 2500000 2500000 > Bad arguments > > Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and > policing") > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com> > --- > app/test-pmd/cmdline_mtr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> Applied to next-qos tree, thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-08 16:08 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-09-12 9:02 [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command Jasvinder Singh 2018-09-25 10:32 ` Iremonger, Bernard 2018-09-25 11:01 ` Singh, Jasvinder 2018-09-25 14:16 ` Iremonger, Bernard 2018-09-25 14:20 ` Singh, Jasvinder 2018-10-01 10:46 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh 2018-10-08 16:08 ` [dpdk-dev] [PATCH] " Dumitrescu, Cristian
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).