From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 0B4231B16A
 for <dev@dpdk.org>; Wed,  3 Oct 2018 15:00:23 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 03 Oct 2018 06:00:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,336,1534834800"; d="scan'208";a="268111237"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by fmsmga005.fm.intel.com with ESMTP; 03 Oct 2018 06:00:21 -0700
Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.110]) with mapi id 14.03.0319.002;
 Wed, 3 Oct 2018 14:00:20 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>,
 "Kovacevic, Marko" <marko.kovacevic@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Andrew
 Rybchenko" <arybchenko@solarflare.com>, Olivier Matz
 <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "shahafs@mellanox.com" <shahafs@mellanox.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
 checksum definition
Thread-Index: AQHUWoW0cd0aS94bbUK6ari/qyspj6UNWHkg///3fgCAACxloA==
Date: Wed, 3 Oct 2018 13:00:20 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C260D0C16E@IRSMSX107.ger.corp.intel.com>
References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com>
 <20181002192451.19119-1-jerin.jacob@caviumnetworks.com>
 <8CEF83825BEC744B83065625E567D7C260D0C0C7@IRSMSX107.ger.corp.intel.com>
 <20181003111901.GB9248@jerin>
In-Reply-To: <20181003111901.GB9248@jerin>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDEwMzIxMDktNGJhNy00MWY3LTkzNDctOWUxODM5NmNhNDkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUlE1SzdBald1WTVEa00rNk5kNWh6SmdGTnVyeklEVUJVWXRISDh0cFwvdkR5NWhQNldFMWhKMTRnQ1wvKzduRnR6In0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
 checksum definition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 13:00:24 -0000


Hi Jerin,

<snip>

> > > Subject: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
> > > checksum definition
> > >
> > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and
> > > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum
> failure.
> > >
> > > - To use hardware Rx outer UDP checksum offload, the user needs to
> > > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in
> slowpath.
> > >
> > > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum
> > > failure similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag.
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > >
> > > v2:
> > > - Removed DEV_RX_OFFLOAD_OUTER_TCP_CKSUM and
> > > DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM as there is no realworld use case
> > > for it.
> > > See: http://patches.dpdk.org/patch/44692/
> > >
> > > This patch series is depended on
> > > http://patches.dpdk.org/patch/45840/
> > >
> > > --
> > >  app/test-pmd/config.c          | 9 +++++++++
> > >  doc/guides/nics/features.rst   | 3 +++
> > >  lib/librte_ethdev/rte_ethdev.c | 1 +
> > > lib/librte_ethdev/rte_ethdev.h | 1 +
> > >  lib/librte_mbuf/rte_mbuf.c     | 2 ++
> > >  lib/librte_mbuf/rte_mbuf.h     | 3 +++
> > >  6 files changed, 19 insertions(+)
> > >
> >
> > <snip>
> >
> > This patch fails to apply to the latest master branch, a rebase may be =
needed.
>=20
>=20
> Have you applies the depended series http://patches.dpdk.org/patch/45840/
> as mentioned above? If yes and then still has issue then let me know.
>=20

The  patches apply and build fine with the above patch applied first.

Regards,

Bernard.