From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6F33B1B436 for ; Thu, 4 Oct 2018 15:45:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 06:45:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,340,1534834800"; d="scan'208";a="269473576" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga006.fm.intel.com with ESMTP; 04 Oct 2018 06:45:43 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX102.ger.corp.intel.com ([169.254.2.67]) with mapi id 14.03.0319.002; Thu, 4 Oct 2018 14:45:42 +0100 From: "Iremonger, Bernard" To: Jerin Jacob , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "shahafs@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine Thread-Index: AQHUW0Vnl9fLMY4FtkyQylQzdZW5vKUPGeCA Date: Thu, 4 Oct 2018 13:45:42 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D0C9DE@IRSMSX107.ger.corp.intel.com> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181003181657.32236-1-jerin.jacob@caviumnetworks.com> <20181003181657.32236-4-jerin.jacob@caviumnetworks.com> In-Reply-To: <20181003181657.32236-4-jerin.jacob@caviumnetworks.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzI0ZDJjMDctMTU3ZC00OTM1LThhMDEtMzBhMThmYzdlNjEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiditCSmlYbHZkNkpJWFRuSk1UcnpWNEQrZ3pFaTlYMzZneFdobk9LdVgwWkxjUFZIQUtaSzUzXC82ZWsraVBYXC9rIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 13:45:52 -0000 Hi Jerin, > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Wednesday, October 3, 2018 7:17 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; shahafs@mellanox.com; Jerin Jacob > > Subject: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 > checksum for csum engine >=20 > Collect and prints the statistics for PKT_RX_EL4_CKSUM_BAD errors. >=20 > Signed-off-by: Jerin Jacob > Reviewed-by: Andrew Rybchenko > --- The following checkpatch warnings should probably be fixed WARNING:LONG_LINE: line over 80 characters #86: FILE: app/test-pmd/testpmd.c:1043: + printf(" Bad-ipcsum: %-14"PRIu64" Bad-l4csum: %-14= "PRIu64"Bad-outer-l4csum: %-14"PRIu64"\n", WARNING:LONG_LINE: line over 80 characters #98: FILE: app/test-pmd/testpmd.c:1063: + printf(" Bad-ipcsum:%14"PRIu64" Bad-l4csum:%14"= PRIu64" Bad-outer-l4csum: %-14"PRIu64"\n", Regards, Bernard.