From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B43A23798 for ; Thu, 4 Oct 2018 17:09:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 08:09:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,340,1534834800"; d="scan'208";a="89168203" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga003.jf.intel.com with ESMTP; 04 Oct 2018 08:06:55 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 4 Oct 2018 16:06:54 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by irsmsx155.ger.corp.intel.com ([169.254.14.27]) with mapi id 14.03.0319.002; Thu, 4 Oct 2018 16:06:53 +0100 From: "Iremonger, Bernard" To: Jerin Jacob CC: "Lu, Wenzhuo" , "Wu, Jingjing" , "dev@dpdk.org" , "shahafs@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine Thread-Index: AQHUW0Vnl9fLMY4FtkyQylQzdZW5vKUPGeCA///4mICAAB3WcA== Date: Thu, 4 Oct 2018 15:06:53 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D0CB87@IRSMSX107.ger.corp.intel.com> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181003181657.32236-1-jerin.jacob@caviumnetworks.com> <20181003181657.32236-4-jerin.jacob@caviumnetworks.com> <8CEF83825BEC744B83065625E567D7C260D0C9DE@IRSMSX107.ger.corp.intel.com> <20181004141647.GA10128@jerin> In-Reply-To: <20181004141647.GA10128@jerin> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzhlMTFkY2UtN2RjZC00NmY3LThkOGItNDlkNTAyMjkzYjZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYmdSOHVaNk40WkkxRm5pMm9FY2RlK1A0blwvMFwvVStpem95YTJWZXVZSkluUTRlcXBxZDJSZW5xT2xvY282VWpWIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 15:09:06 -0000 Hi Jerin, > > > Subject: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 > > > checksum for csum engine > > > > > > Collect and prints the statistics for PKT_RX_EL4_CKSUM_BAD errors. > > > > > > Signed-off-by: Jerin Jacob > > > Reviewed-by: Andrew Rybchenko > > > --- > > > > > > > > The following checkpatch warnings should probably be fixed > > > > WARNING:LONG_LINE: line over 80 characters > > #86: FILE: app/test-pmd/testpmd.c:1043: > > + printf(" Bad-ipcsum: %-14"PRIu64" Bad-l4csum: > > + %-14"PRIu64"Bad-outer-l4csum: %-14"PRIu64"\n", > > > > WARNING:LONG_LINE: line over 80 characters > > #98: FILE: app/test-pmd/testpmd.c:1063: > > + printf(" Bad-ipcsum:%14"PRIu64" Bad-l4csum:= %14"PRIu64" > Bad-outer-l4csum: %-14"PRIu64"\n", > > >=20 > AFAIK, printf's string can be >80 to allow string strip Yes, there is flexibility, not sure how much, the above lines are > 100 cha= rs. Otherwise Acked-by: Bernard Iremonger =20