From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bernard.iremonger@intel.com> Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C4B79160 for <dev@dpdk.org>; Mon, 8 Oct 2018 12:01:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 03:01:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,356,1534834800"; d="scan'208";a="77061418" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga008.fm.intel.com with ESMTP; 08 Oct 2018 03:01:49 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX108.ger.corp.intel.com ([169.254.11.187]) with mapi id 14.03.0319.002; Mon, 8 Oct 2018 11:01:48 +0100 From: "Iremonger, Bernard" <bernard.iremonger@intel.com> To: Raslan Darawsheh <rasland@mellanox.com>, "Wu, Jingjing" <jingjing.wu@intel.com> CC: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>, "Xueming(Steven) Li" <xuemingl@mellanox.com>, Ori Kam <orika@mellanox.com>, "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>, "david.marchand@6wind.com" <david.marchand@6wind.com> Thread-Topic: [PATCH v4 1/3] app/testpmd: move dumping packets to a separate function Thread-Index: AQHUXhCzYPX+NmU940ikAW6k8PkN86UVH2Gw Date: Mon, 8 Oct 2018 10:01:47 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D0DB90@IRSMSX107.ger.corp.intel.com> References: <1537793304-27883-1-git-send-email-rasland@mellanox.com> <1538897848-1693-1-git-send-email-rasland@mellanox.com> In-Reply-To: <1538897848-1693-1-git-send-email-rasland@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk4YWFiMTUtNWYyMC00ODQ0LWE4ZDMtZWY2N2E0YmFjZDdmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNmtpMXBNcTAxbVwvQ3hTdTNtdGU5UXJ2SmMxcVhmUlFDaVlmcUtYV0xBaEtBeVF6QWJkMzc1NFFIelNxbWZBamsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: move dumping packets to a separate function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 08 Oct 2018 10:02:00 -0000 > -----Original Message----- > From: Raslan Darawsheh [mailto:rasland@mellanox.com] > Sent: Sunday, October 7, 2018 8:38 AM > To: Wu, Jingjing <jingjing.wu@intel.com> > Cc: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org; Shahaf Shuler > <shahafs@mellanox.com>; Raslan Darawsheh <rasland@mellanox.com>; > Xueming(Steven) Li <xuemingl@mellanox.com>; Ori Kam > <orika@mellanox.com>; jerin.jacob@caviumnetworks.com; > david.marchand@6wind.com; Iremonger, Bernard > <bernard.iremonger@intel.com> > Subject: [PATCH v4 1/3] app/testpmd: move dumping packets to a separate > function >=20 > verbosity for the received/sent packets is needed in all of the forwardin= g > engines so moving it to be in a separate function >=20 > --- > changes in v3: > - add util.c in the mason.build file > - restore missing check for ol_flags & PKT_RX_RSS_HASH. > - add local variables for rte_be_to_cpu to avoid long > lines. >=20 > changes in v4: > - add missing l3 and l4 checks > --- >=20 > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>