From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4D2C41B143 for ; Thu, 18 Oct 2018 18:42:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2018 09:42:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,397,1534834800"; d="scan'208";a="82263885" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga007.jf.intel.com with ESMTP; 18 Oct 2018 09:42:50 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX102.ger.corp.intel.com ([169.254.2.67]) with mapi id 14.03.0319.002; Thu, 18 Oct 2018 17:42:49 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "ophirmu@mellanox.com" , "rahul.lakkireddy@chelsio.com" , Wisam Jaddo Thread-Topic: [dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after removing several at once Thread-Index: AQHUZoFIrvqYSgZKkECV9iUkxJ1NeaUky2UAgAACaACAABM8gIAAHOgAgAA2/5A= Date: Thu, 18 Oct 2018 16:42:48 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D12F43@IRSMSX107.ger.corp.intel.com> References: <20180907233929.21950-1-thomas@monjalon.net> <4896325.UA0OBGhyO2@xps> <8CEF83825BEC744B83065625E567D7C260D12D5C@IRSMSX107.ger.corp.intel.com> <4688337.PUasVPICMu@xps> In-Reply-To: <4688337.PUasVPICMu@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2ViZTE5MzktZGYyMy00NDNjLTkxMWUtMjZlYzIyZTBlNTFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYTZUeDlndE1Qdytub3ZsTEJiamJSOWU3cFdoaVdqb3VTVDRaU2plbEU2dEJFcE1yUlpBa1ZcL2pBNlpxSDZXTGwifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after removing several at once X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 16:42:53 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, October 18, 2018 3:21 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org; Yigit, Ferruh ; > arybchenko@solarflare.com; ophirmu@mellanox.com; > rahul.lakkireddy@chelsio.com; Wisam Jaddo > Subject: Re: [dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after > removing several at once >=20 > 18/10/2018 13:41, Iremonger, Bernard: > > Hi Thomas > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 18/10/2018 12:40, Iremonger, Bernard: > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > > > > From: Wisam Jaddo > > > > > > > > > > When detaching a port, the full rte_device is removed. > > > > > If the rte_device was hosting several ports, the testpmd list of > > > > > ports must be updated for multiple removals. > > > > > > > > ./devtools/check-git-log.sh -1 > > > > Missing 'Fixes' tag: > > > > app/testpmd: fix ports list after removing several at once > > > > > > I think it is OK. > > > It is fixing a case which was not tested before. > > > And we don't really need to backport it. > > > > If "fix" is removed from the commit message then the fixes line will no= t be > needed. > > However if it is a real fix, then I think fixes line should be added . >=20 > I know, I am the one implementing this check :-) If I add a Fixes: line, = it will warn > about a lack of Cc:stable. > But we don't need to backport this. > That's why I think we can ignore this warning. >=20 > Reminder: it is just warning, not a mandatory requirement. >=20 >=20 As this does not seem to be a normal "fix", how about replacing "fix" with = something like "update", then there will be no warning to ignore. Better not have warnings. Regards, Bernard.