From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E2F911B202 for ; Fri, 19 Oct 2018 16:32:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Oct 2018 07:32:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,400,1534834800"; d="scan'208";a="82803028" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga008.jf.intel.com with ESMTP; 19 Oct 2018 07:32:54 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX109.ger.corp.intel.com ([169.254.13.183]) with mapi id 14.03.0319.002; Fri, 19 Oct 2018 15:32:53 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon , "Yigit, Ferruh" , "arybchenko@solarflare.com" CC: "dev@dpdk.org" , "ophirmu@mellanox.com" , "rahul.lakkireddy@chelsio.com" Thread-Topic: [PATCH v6 2/6] app/testpmd: allow detaching a port not closed Thread-Index: AQHUZ1CrUMKG984G40e4BfhbDNd/TKUmog+w Date: Fri, 19 Oct 2018 14:32:53 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D1431F@IRSMSX107.ger.corp.intel.com> References: <20180907233929.21950-1-thomas@monjalon.net> <20181019020757.27698-1-thomas@monjalon.net> <20181019020757.27698-3-thomas@monjalon.net> In-Reply-To: <20181019020757.27698-3-thomas@monjalon.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzdhMzIwN2ItYzVmMC00N2E2LWEwMjMtNGU3YWI0Y2NlZTExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMFNNS25pR0VwR2YzckVcL3oxZHNsS3FEV29zVmlxUHZzWnprR0JneXhQeENxOWNMWEhvWHk2V1l4M3BmQ25jVUgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/6] app/testpmd: allow detaching a port not closed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2018 14:32:57 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, October 19, 2018 3:08 AM > To: Yigit, Ferruh ; arybchenko@solarflare.com > Cc: dev@dpdk.org; ophirmu@mellanox.com; Iremonger, Bernard > ; rahul.lakkireddy@chelsio.com > Subject: [PATCH v6 2/6] app/testpmd: allow detaching a port not closed >=20 > The testpmd application aim is for testing; so order of operations should= not > be enforced. >=20 > There was a test to forbid detaching before closing a port. > However, it may interesting to test what happens in such case. > It is possible for a PMD to automatically close the port when detaching. >=20 > in order to avoid a crash, it is checked that the port must be stopped be= fore > detaching (as for closing). >=20 > Signed-off-by: Thomas Monjalon Acked-by: Bernard Iremonger